Closed Bug 749520 Opened 12 years ago Closed 12 years ago

Use new mozHasAudio API to let users know that the video being watched does not have an audio track

Categories

(Toolkit :: Video/Audio Controls, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: jaws, Assigned: padenot)

References

(Depends on 1 open bug)

Details

Attachments

(1 file, 5 obsolete files)

Bug 480376 is adding a new mozHasAudio API that can be used to determine if the current video has any audio tracks.

Videos that don't contain audio tracks should have a warning/info bar that lets the user know that their speakers aren't broken. See https://bugzilla.mozilla.org/attachment.cgi?id=364363 for an example.
Assignee: nobody → paul
Attached patch Possible fix with horrible UI. (obsolete) — Splinter Review
Here is a possible fix. No attempt has been made to make it pretty (only a quick strike trough in gimp).
Attachment #619784 - Flags: feedback?(dolske)
Attached patch Revised patch. (obsolete) — Splinter Review
Fixing a wrong behavior and changing review. This still needs a better UI.
Attachment #619784 - Attachment is obsolete: true
Attachment #619784 - Flags: feedback?(dolske)
Attachment #622979 - Flags: feedback?(jaws)
Comment on attachment 622979 [details] [diff] [review]
Revised patch.

Review of attachment 622979 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Please ask Stephen in #ux if he has any ideas for the icon. I think we can do a speaker without the sound waves coming out that is behind the "no-smoking" type circle.
Attachment #622979 - Flags: feedback?(jaws) → feedback+
Stephen, any new regarding a possible icon for this feature ?
Attachment #622979 - Attachment is obsolete: true
Attachment #626911 - Attachment is obsolete: true
Attachment #626950 - Flags: review?(jaws)
Comment on attachment 626950 [details] [diff] [review]
Folded patch including shorlander's icon

Review of attachment 626950 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/themes/winstripe/global/jar.mn
@@ +149,5 @@
>          skin/classic/global/media/pauseButton.png                (media/pauseButton.png)
>          skin/classic/global/media/playButton.png                 (media/playButton.png)
>          skin/classic/global/media/muteButton.png                 (media/muteButton.png)
>          skin/classic/global/media/unmuteButton.png               (media/unmuteButton.png)
> +        skin/classic/global/media/noAudio.png                    (media/noAudio.png)

You need to also duplicate this for aero.
Attachment #626950 - Flags: review?(jaws) → review-
Attached patch Addressed Jared's comments. (obsolete) — Splinter Review
Attachment #626950 - Attachment is obsolete: true
Attachment #628128 - Flags: review?(jaws)
Comment on attachment 628128 [details] [diff] [review]
Addressed Jared's comments.

Review of attachment 628128 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!
Attachment #628128 - Flags: review?(jaws) → review+
Attachment #628128 - Attachment is obsolete: true
Keywords: checkin-needed
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/730209ed620b
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 762933
Depends on: 768937
You need to log in before you can comment on or make changes to this bug.