The default bug view has changed. See this FAQ.

SkAdvancedTypefaceMetrics.cpp:19:52: fatal error: ApplicationServices/ApplicationServices.h: No such file or directory on Hurd and kFreeBSD

RESOLVED FIXED in mozilla15

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla15
All
Other
Points:
---

Firefox Tracking Flags

(firefox12 affected, firefox13 affected, firefox14 affected)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 618940 [details] [diff] [review]
Add support for GNU/kFreeBSD and Hurd in SKIA

I'll check if more is needed.
Attachment #618940 - Flags: review?(bjacob)
(Assignee)

Updated

5 years ago
status-firefox12: --- → affected
status-firefox13: --- → affected
status-firefox14: --- → affected
(Assignee)

Comment 2

5 years ago
Created attachment 619001 [details] [diff] [review]
Add support for GNU/kFreeBSD and Hurd in SKIA
Attachment #619001 - Flags: review?(bjacob)
(Assignee)

Updated

5 years ago
Attachment #618940 - Attachment is obsolete: true
Attachment #618940 - Flags: review?(bjacob)
Comment on attachment 619001 [details] [diff] [review]
Add support for GNU/kFreeBSD and Hurd in SKIA

I worry that this relies on GLIBC not being used by unrelated operating systems. Did you mean (defined(__GLIBC__) && defined(__GNU__)) instead ?
(Assignee)

Comment 4

5 years ago
(In reply to Benoit Jacob [:bjacob] from comment #3)
> Comment on attachment 619001 [details] [diff] [review]
> Add support for GNU/kFreeBSD and Hurd in SKIA
> 
> I worry that this relies on GLIBC not being used by unrelated operating
> systems. Did you mean (defined(__GLIBC__) && defined(__GNU__)) instead ?

GLIBC is what provides the "unix" libc. Whatever kernel it runs on will thus expose the libc functions. It so happens that GNU/kfreeBSD is such a system: it has the glibc, and uses a FreeBSD kernel. Its compiler defines __GLIBC__. GNU/Hurd, however, while it comes with glibc (obviously), doesn't define __GLIBC__. It defines __GNU__ instead.

So we need to check for both, individually.
Attachment #619001 - Flags: review?(bjacob) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2408bf119fbf
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/2408bf119fbf
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.