Last Comment Bug 749533 - SkAdvancedTypefaceMetrics.cpp:19:52: fatal error: ApplicationServices/ApplicationServices.h: No such file or directory on Hurd and kFreeBSD
: SkAdvancedTypefaceMetrics.cpp:19:52: fatal error: ApplicationServices/Applica...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: All Other
: -- normal (vote)
: mozilla15
Assigned To: Mike Hommey [:glandium]
:
: Milan Sreckovic [:milan]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-26 23:32 PDT by Mike Hommey [:glandium]
Modified: 2012-05-04 02:57 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
affected
affected
affected


Attachments
Add support for GNU/kFreeBSD and Hurd in SKIA (1.19 KB, patch)
2012-04-26 23:38 PDT, Mike Hommey [:glandium]
no flags Details | Diff | Splinter Review
Add support for GNU/kFreeBSD and Hurd in SKIA (1.21 KB, patch)
2012-04-27 05:57 PDT, Mike Hommey [:glandium]
jacob.benoit.1: review+
Details | Diff | Splinter Review

Description Mike Hommey [:glandium] 2012-04-26 23:32:44 PDT

    
Comment 1 Mike Hommey [:glandium] 2012-04-26 23:38:44 PDT
Created attachment 618940 [details] [diff] [review]
Add support for GNU/kFreeBSD and Hurd in SKIA

I'll check if more is needed.
Comment 2 Mike Hommey [:glandium] 2012-04-27 05:57:02 PDT
Created attachment 619001 [details] [diff] [review]
Add support for GNU/kFreeBSD and Hurd in SKIA
Comment 3 Benoit Jacob [:bjacob] (mostly away) 2012-04-27 05:59:49 PDT
Comment on attachment 619001 [details] [diff] [review]
Add support for GNU/kFreeBSD and Hurd in SKIA

I worry that this relies on GLIBC not being used by unrelated operating systems. Did you mean (defined(__GLIBC__) && defined(__GNU__)) instead ?
Comment 4 Mike Hommey [:glandium] 2012-04-27 06:08:40 PDT
(In reply to Benoit Jacob [:bjacob] from comment #3)
> Comment on attachment 619001 [details] [diff] [review]
> Add support for GNU/kFreeBSD and Hurd in SKIA
> 
> I worry that this relies on GLIBC not being used by unrelated operating
> systems. Did you mean (defined(__GLIBC__) && defined(__GNU__)) instead ?

GLIBC is what provides the "unix" libc. Whatever kernel it runs on will thus expose the libc functions. It so happens that GNU/kfreeBSD is such a system: it has the glibc, and uses a FreeBSD kernel. Its compiler defines __GLIBC__. GNU/Hurd, however, while it comes with glibc (obviously), doesn't define __GLIBC__. It defines __GNU__ instead.

So we need to check for both, individually.
Comment 6 Ed Morley [:emorley] 2012-05-04 02:57:00 PDT
https://hg.mozilla.org/mozilla-central/rev/2408bf119fbf

Note You need to log in before you can comment on or make changes to this bug.