Closed Bug 749550 Opened 8 years ago Closed 8 years ago

dbg-server.jsm includes dbg-client.jsm with resource:/// instead of resource://gre/

Categories

(DevTools :: Debugger, defect)

13 Branch
defect
Not set

Tracking

(firefox12 unaffected, firefox13 unaffected, firefox14 fixed)

RESOLVED FIXED
Firefox 15
Tracking Status
firefox12 --- unaffected
firefox13 --- unaffected
firefox14 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

No description provided.
https://hg.mozilla.org/mozilla-central/rev/925d9ca6a866
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment on attachment 618957 [details] [diff] [review]
Import dbg-client.jsm from resource://gre/ instead of resource:///

[Approval Request Comment]
Regression caused by: bug 740803
User impact if declined: Debugger probably doesn't work on Firefox-on-xulrunner setups (used by some Linux distros)
Testing completed (on m-c, etc.): Landed on m-c a couple days ago.
Risk to taking this patch (and alternatives if risky): None. on Mozilla builds, resource://gre/ and resource:/// are strictly identical.
String changes made by this patch: None.
Attachment #618957 - Flags: approval-mozilla-aurora?
Comment on attachment 618957 [details] [diff] [review]
Import dbg-client.jsm from resource://gre/ instead of resource:///

(In reply to Mike Hommey [:glandium] from comment #4)
> User impact if declined: Debugger probably doesn't work on
> Risk to taking this patch (and alternatives if risky): None. on Mozilla
> builds, resource://gre/ and resource:/// are strictly identical.

Although we're not 100% sure of the user impact, it sounds like we're nearly 100% sure we won't cause a regression. Approving for Aurora 14.
Attachment #618957 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.