Closed Bug 749552 Opened 12 years ago Closed 12 years ago

The Command+K keyboard shortcut should select for chat search box when the chat tab is selected

Categories

(Thunderbird :: Instant Messaging, defect)

Product:
Thunderbird
Component:
Instant Messaging
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird14 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 15.0
Tracking Flags:
Tracking Status
thunderbird14 --- fixed

People

(Reporter: florian, Assigned: florian)

Details

Attachments

(1 file)

Patch
847 bytes, patch
mconley
: review+
Bienvenu
: approval-comm-aurora+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
The empty text of the IM search box shows the Command+K keyboard shortcut (consistent with search boxes of other tabs) so it should work.
Attachment #618980 - Flags: review?(mconley)
Comment on attachment 618980 [details] [diff] [review]
Patch

Review of attachment 618980 [details] [diff] [review]:
-----------------------------------------------------------------

This looks OK - but squib is right, we should probably abstract this out into a Command at some point.  I'll file a bug.
Attachment #618980 - Flags: review?(mconley) → review+
(In reply to Mike Conley (:mconley) from comment #1)
> we should probably abstract this out into a Command at some point.
> I'll file a bug.

This was filed as bug 749599.

http://hg.mozilla.org/comm-central/rev/2981746a1d7d
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
Attachment #618980 - Flags: approval-comm-aurora?
Attachment #618980 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: