74972 - workaround for suggested word shrinkage at end of spellcheck

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P4)

Description

[[e-mail]]

Index: EdSpellCheck.js
===================================================================
RCS file: /cvsroot/mozilla/editor/ui/dialogs/content/EdSpellCheck.js,v
retrieving revision 1.33
diff -u -r1.33 EdSpellCheck.js
--- EdSpellCheck.js     2001/04/04 04:05:14     1.33
+++ EdSpellCheck.js     2001/04/06 10:58:32
@@ -422,6 +422,9 @@
       // Initialize with first suggested list by selecting it
       dialog.SuggestedList.selectedIndex = 0;
     }
+  } else {
+    var item = AppendStringToTreelist(list, "");
+    if (item) item.setAttribute("disabled", "true");
   }
 }

Comment 1

[rubydoo123]

assigning to kin for review of suggested patch

Comment 2

[kinmoz]

cmanske can you give an r= on this patch if you're ok with it?

Comment 3

[Charles Manske]

I already have a "workaround" solution very close to Neil's in my tree, but this
is for the list layout problem (bug 74467) in the Spelling Dictionary dialog.
What exactly is the problem in the spell dialog that this is solving?
The complete block before the suggested patch is this:
    if (count == 0) {
      // No suggestions - show a message but don't let user select it
      var item = AppendStringToTreelistById(list, "NoSuggestedWords");
      if (item) item.setAttribute("disabled", "true");
      allowSelectWord = false;
    } else {
      allowSelectWord = true;
      // Initialize with first suggested list by selecting it
      dialog.SuggestedList.selectedIndex = 0;
    }

So we are putting a string ("No suggested words") in the list when none are
found supplied by spell checker.
So I don't see how this code can be reached.

Comment 4

[kinmoz]

I think his "else" clause corresponds to the if (MisspelledWord.length > 0).

Comment 5

[Charles Manske]

Got it. It's exactly the same issue as in the Dictionary dialog.
I pinged hyatt and he says he'll look at the issue (bug 74467) soon.
Let's hold off on any workarounds.

Comment 6

[Charles Manske]

Neil: I think "Suggested word list in Spelling Dialog doesn't size correctly
when there are no misspelled words" accurately describes the problem, correct?

Comment 7

[Charles Manske]

Sorry for another message, but I should take this.
Also changing milestone to 0.9.1

Comment 8

[Charles Manske]

Will be fixed when 74467 is fixed, else we will add a blank item as suggested
by Neil.

Comment 9

[Charles Manske]

The workaround is easy -- will do for 9.1
so this is really a dup of 67242

*** This bug has been marked as a duplicate of 67242 ***

Comment 10

[sujay]

verified in 5/9 build.

Comment 11

[Charles Manske]

This is NOT a dup of bug 67242 -- that was about spelling dictionary dialog.

Comment 12

[Charles Manske]

Attachment: This is essentially the same as Neil's suggested fix

Comment 13

[Charles Manske]

r=cmanske. Need sr.

Comment 14

[kinmoz]

sr=[e-mail]

Comment 15

[Charles Manske]

checked in.

Comment 16

[sujay]

marking verified.