mozharness multilocale will detect missing tags, but not fail out

RESOLVED FIXED

Status

Release Engineering
Applications: MozharnessCore
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: aki, Assigned: aki)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozharness])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
This is probably fine for 10.0.4esr, but we should catch this going forward.
(Assignee)

Updated

6 years ago
Blocks: 749542
(Assignee)

Comment 1

6 years ago
Created attachment 619161 [details] [diff] [review]
this should do it
(Assignee)

Comment 2

6 years ago
Created attachment 620435 [details] [diff] [review]
only fatal() on return code != 0

Tested using:

# Good revision
mozharness/scripts/hgtool.py -r default http://hg.mozilla.org/build/tools

# Bad revision
mozharness/scripts/hgtool.py -r defaultblah http://hg.mozilla.org/build/tools

The latter fatal()s out.

Also, feeling guilty for sending so many reviews your way.
Attachment #619161 - Attachment is obsolete: true
Attachment #620435 - Flags: review?(rail)
Comment on attachment 620435 [details] [diff] [review]
only fatal() on return code != 0

(In reply to Aki Sasaki [:aki] from comment #2)
> Also, feeling guilty for sending so many reviews your way.

anytime!
Attachment #620435 - Flags: review?(rail) → review+
(Assignee)

Comment 4

6 years ago
Comment on attachment 620435 [details] [diff] [review]
only fatal() on return code != 0

http://hg.mozilla.org/build/mozharness/rev/ea1d9f46c6ca
Attachment #620435 - Flags: checked-in+
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering

Updated

4 years ago
Component: General Automation → Mozharness
You need to log in before you can comment on or make changes to this bug.