Closed Bug 749750 Opened 8 years ago Closed 8 years ago
Bridge::Create Surface returns local ref
AndroidBridge::CreateSurface calls NewGlobalRef, but doesn't assign the result. Consequently, the local ref is returned, which causes problems on API v14 due to the closing of this loophole.
8 years ago
blocking-fennec1.0: --- → ?
Attachment #619141 - Flags: review?(blassey.bugs) → review+
Comment on attachment 619141 [details] [diff] [review] Correctly ref created Surfaces on Android [Approval Request Comment] Trivial patch, no risk, blocks 746703
Attachment #619141 - Flags: approval-mozilla-aurora?
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 14 → Firefox 15
QA: please test to see if this possibly fixes 738198
Let's find out if this is blocking fennec 1.0 before approving for Aurora 14.
(In reply to James Willcox (:snorp) (firstname.lastname@example.org) from comment #5) > QA: please test to see if this possibly fixes 738198 Crashes that are related to Bug 738198 have been reproduced on Nightly/15.0a1 2012-05-01 on a Motorola Droid Pro(Android 2.3.4). The issue does not seem to be fixed by this patch.
Comment on attachment 619141 [details] [diff] [review] Correctly ref created Surfaces on Android [Triage Comment] Approving along with bug 746703 for Aurora 14.
Attachment #619141 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Duplicate of this bug: 752000
You need to log in before you can comment on or make changes to this bug.