Closed Bug 749772 Opened 13 years ago Closed 12 years ago

Hotkeys documentation should give some guidance about acceptable hotkeys

Categories

(Add-on SDK Graveyard :: Documentation, defect, P2)

Product:
Add-on SDK Graveyard
Component:
Documentation
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: wbamberg, Assigned: wbamberg)

References

Details

Attachments

(1 file)

add guidance on hotkeys
2.52 KB, patch
mossop
: review+
Details | Diff | Splinter Review
In this forum post: https://forums.mozilla.org/addons/viewtopic.php?f=27&t=8110 a developer tries to use hotkey combinations that fail review, although the hotkey module allows them. We should at least give guidance in the documentation about which hotkeys a developer should not use, and what they should consider when choosing hotkeys in order to interact nicely with the browser and with other add-ons.
Priority: -- → P2
Assignee: nobody → wbamberg
I've taken this guidance from Jorge and iann's sensible-looking comments in https://forums.mozilla.org/addons/viewtopic.php?f=27&t=8110.
Attachment #700771 - Flags: review?(dtownsend+bugmail)
Attachment #700771 - Flags: review?(dtownsend+bugmail) → review+
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/dad06901db0a73c9c162b5afcfdfe11a0d8ba50a Fix bug 749772 - Hotkeys documentation should give some guidance about acceptable hotkeys; r=@mossop
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/fcdb4180fe7f17d831a4945a7d32a1b89a84ed8c Fix bug 749772 - Hotkeys documentation should give some guidance about acceptable hotkeys; r=@mossop
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: