Closed Bug 749814 Opened 10 years ago Closed 10 years ago

Search suggestions do not work in mobile because of onkeyup

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED
2012-05-31

People

(Reporter: cvan, Assigned: cvan)

References

()

Details

(Whiteboard: [woomp])

Because `onkeyup` and `onkeypress` don't get fired in mobile, we aren't detecting when people type something into the search box. As a result the search suggestions box doesn't appear at all!
Blocks: 752013
No longer blocks: 735054
Priority: -- → P3
14:32 < davidwalsh|brb> cvan: During the focus event, I'd add a listener which would use setInterval to evaluate the value of the input every, say second, and use that value to provide suggestions
14:32 < davidwalsh|brb> When the field was blurred, I'd remove the event to release the setInterval stress
...
14:40 < digitarald> +1 on interval-while-focussed always works best
...
14:41 < digitarald> somebody committed my code here, its basically this class with option periodical: true 
https://github.com/angelsk/mootools-autocompleter/blob/f81253a35d63336c955b94b916b4a9f3ab7c7d25/Source/Observer.js
Blocks: 756282
No longer blocks: 752013
Component: Public Pages → Consumer Pages
Product: addons.mozilla.org → Marketplace
QA Contact: web-ui → consumer-pages
Version: unspecified → 1.0
Assignee: nobody → cvan
Whiteboard: [woomp]
Target Milestone: --- → 2012-05-31
https://github.com/mozilla/zamboni/commit/79f307d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified as fixed : http://screencast.com/t/q1StLqBJg
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.