749862 - findElements with css selector only returns a single element

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[James Lal [:lightsofapollo]]

Attachment: Target html fragment

While testing the marionette js driver I found that findElements fails to return all of the elements that match the selector.

in the python driver I see a similar result except it causes an error inside
the python script.

//start session
marionette.find_elements('css selector', 'div');
// one element returns
marionette.find_elements('tag name', 'div');
//42 elements
marionette.execute_script('return document.querySelectorAll(\'div\').length; ');
//42 elements

Attached is the contents of the body element on the page I was testing this command on. This is actually the system app in b2g.

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: Fix v0.1

querySelectorAll returns a NodeList, and not a list of elements, so this was just a quick fix.

I found a similar problem with find_elements("name",...), so I fixed that in this patch.

I updated the tests to try a basic find_elements() call for each supported search type.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 621714 [details] [diff] [review]
Fix v0.1

Review of attachment 621714 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/marionette-elements.js
@@ +402,5 @@
>          elements = this.findByXPathAll(rootNode, value, startNode);
>          break;
>        case NAME:
> +        elements = startNode.getElementsByName ?
> +                  startNode.getElementsByName(value) : 

reindent

@@ +429,5 @@
>        case SELECTOR:
> +        let matches = rootNode.querySelectorAll(value);
> +        for (let i = 0; i <  matches.length; i++) {
> +          elements.push(matches[i]);
> +        }

elements = Array.prototype.slice.call(matches);

tends to be how people do this

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: Fix v0.2

Thanks, I've updated the patch

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 621727 [details] [diff] [review]
Fix v0.2

Thanks!

Comment 5

[Jonathan Griffin (:jgriffin)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/6d4fbeb32fbf

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6d4fbeb32fbf