749955 - Update en-GB for SeaMonkey 2.10

Status: RESOLVED FIXED

Description

[Ian Neal]

Created attachment 619307 [details] [diff] [review]
SeaMonkey 2.10 en-GB update [Checked in: Comment 2]

Update en-GB for SeaMonkey 2.10, this depends on the patches for Gecko (bug 747345) and Editor (bug 747360).

Comment 1

[Ian Neal]

Created attachment 619320 [details] [diff] [review]
SeaMonkey 2.10 Help en-GB update [Checked in: Comment 3]

Update en-GB for SeaMonkey 2.10 Help

Comment 2

[Ian Neal]

Comment on attachment 619307 [details] [diff] [review]
SeaMonkey 2.10 en-GB update [Checked in: Comment 2]

http://hg.mozilla.org/releases/l10n/mozilla-beta/en-GB/rev/e2938a12387f
http://hg.mozilla.org/releases/l10n/mozilla-aurora/en-GB/rev/7b3b80d4d38e

Comment 3

[Ian Neal]

Comment on attachment 619320 [details] [diff] [review]
SeaMonkey 2.10 Help en-GB update [Checked in: Comment 3]

http://hg.mozilla.org/releases/l10n/mozilla-beta/en-GB/rev/f968240e6df8
http://hg.mozilla.org/releases/l10n/mozilla-aurora/en-GB/rev/e171fc08fde6

Comment 4

[Mark Tyndall]

Comment on attachment 619307 [details] [diff] [review]
SeaMonkey 2.10 en-GB update [Checked in: Comment 2]

Review of attachment 619307 [details] [diff] [review]:
-----------------------------------------------------------------

::: suite/chrome/mailnews/pref/pref-composing_messages.dtd
@@ +85,5 @@
> +  combination of the mailnews.reply_header_authorwrote([Author] wrote), 
> +  mailnews.reply_header_separator (a comma in this case), and 
> +  mailnews.reply_header_ondate preferences(On [date]). [Author] and [date] 
> +  need to be translated, and the correct separator put in. -->
> +<!ENTITY authorWroteOnDateOption.label        "[Author] wrote, On [date]:">

Can't help feeling that [Author] wrote, _o_n [date] would be better, but the Localization Note isn't very helpful

Comment 5

[Mark Tyndall]

Comment on attachment 619320 [details] [diff] [review]
SeaMonkey 2.10 Help en-GB update [Checked in: Comment 3]

Review of attachment 619320 [details] [diff] [review]:
-----------------------------------------------------------------

::: suite/chrome/common/help/mailnews_preferences.xhtml
@@ +296,5 @@
> +      <li>On [date], [author] wrote:<br/>
> +        This setting is based on a combination of the mailnews.reply_header_ondate, 
> +        mailnews.reply_header_separator and mailnews.reply_header_authorwrote 
> +        preferences.</li>
> +      <li>[Author] wrote, On [date]:<br/>

As for the earlier review, this would be better as:
<li>[Author] wrote, on [date]:<br/>

Comment 6

[Ian Neal]

(In reply to Mark Tyndall from comment #4)
> Comment on attachment 619307 [details] [diff] [review]
> SeaMonkey 2.10 en-GB update [Checked in: Comment 2]
> 
> Review of attachment 619307 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: suite/chrome/mailnews/pref/pref-composing_messages.dtd
> @@ +85,5 @@
> > +  combination of the mailnews.reply_header_authorwrote([Author] wrote), 
> > +  mailnews.reply_header_separator (a comma in this case), and 
> > +  mailnews.reply_header_ondate preferences(On [date]). [Author] and [date] 
> > +  need to be translated, and the correct separator put in. -->
> > +<!ENTITY authorWroteOnDateOption.label        "[Author] wrote, On [date]:">
> 
> Can't help feeling that [Author] wrote, _o_n [date] would be better, but the
> Localization Note isn't very helpful

At the moment the same entity for "On" is used no matter what the order which means it does appear in mail as something like "Mark wrote, On 8/6/2012:", so this should match current behaviour :(