750018 - Missing format strings

Status: RESOLVED FIXED

(NSS :: Tools, defect)

Description

[Mike Hommey [:glandium]]

Somehow similar to bug 521679, there are a few printfs called without a format string, that is, it just uses a buffer it is passed as the format string. If one of these buffers contain %something, it will start having interesting behavior. Arguably, this is only in tools, but it also silences gcc when building with some hardening options.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Add %s format strings to many {,f}printf calls

Comment 2

[Kai Engert (:KaiE:)]

Comment on attachment 619360 [details] [diff] [review]
Add %s format strings to many {,f}printf calls

r=kaie
Thank you for the patch

Comment 3

[Kai Engert (:KaiE:)]

Checking in certcgi/certcgi.c;
/cvsroot/mozilla/security/nss/cmd/certcgi/certcgi.c,v  <--  certcgi.c
new revision: 1.21; previous revision: 1.20
done
Checking in digest/digest.c;
/cvsroot/mozilla/security/nss/cmd/digest/digest.c,v  <--  digest.c
new revision: 1.7; previous revision: 1.6
done
Checking in signver/pk7print.c;
/cvsroot/mozilla/security/nss/cmd/signver/pk7print.c,v  <--  pk7print.c
new revision: 1.12; previous revision: 1.11
done