Last Comment Bug 750063 - Allow passing null to nsTextEditRules::CreateMozBR's outparam
: Allow passing null to nsTextEditRules::CreateMozBR's outparam
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: :Ms2ger
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-29 07:08 PDT by :Ms2ger
Modified: 2012-05-05 10:28 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (9.57 KB, patch)
2012-04-29 07:08 PDT, :Ms2ger
ehsan: review+
Details | Diff | Review

Description :Ms2ger 2012-04-29 07:08:39 PDT
Created attachment 619394 [details] [diff] [review]
Patch v1

Most callers don't want the return value, so it makes more sense not to require keeping a local pointer around for it.
Comment 1 :Ehsan Akhgari (busy, don't ask for review please) 2012-04-30 11:00:35 PDT
Comment on attachment 619394 [details] [diff] [review]
Patch v1

Review of attachment 619394 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/text/nsTextEditRules.h
@@ +226,5 @@
>    /** Remove IME composition text from password buffer */
>    nsresult RemoveIMETextFromPWBuf(PRUint32 &aStart, nsAString *aIMEString);
>  
> +  nsresult CreateMozBR(nsIDOMNode* inParent, PRInt32 inOffset,
> +                       nsIDOMNode** outBRNode = NULL);

Nit: nsnull

Note You need to log in before you can comment on or make changes to this bug.