Closed
Bug 750063
Opened 12 years ago
Closed 12 years ago
Allow passing null to nsTextEditRules::CreateMozBR's outparam
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
9.57 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
Most callers don't want the return value, so it makes more sense not to require keeping a local pointer around for it.
Attachment #619394 -
Flags: review?(ehsan)
Comment 1•12 years ago
|
||
Comment on attachment 619394 [details] [diff] [review] Patch v1 Review of attachment 619394 [details] [diff] [review]: ----------------------------------------------------------------- ::: editor/libeditor/text/nsTextEditRules.h @@ +226,5 @@ > /** Remove IME composition text from password buffer */ > nsresult RemoveIMETextFromPWBuf(PRUint32 &aStart, nsAString *aIMEString); > > + nsresult CreateMozBR(nsIDOMNode* inParent, PRInt32 inOffset, > + nsIDOMNode** outBRNode = NULL); Nit: nsnull
Attachment #619394 -
Flags: review?(ehsan) → review+
Assignee | ||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3859550a1cbb
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•