Allow passing null to nsTextEditRules::CreateMozBR's outparam

RESOLVED FIXED in mozilla15

Status

()

Core
Editor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 619394 [details] [diff] [review]
Patch v1

Most callers don't want the return value, so it makes more sense not to require keeping a local pointer around for it.
Attachment #619394 - Flags: review?(ehsan)
Comment on attachment 619394 [details] [diff] [review]
Patch v1

Review of attachment 619394 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/text/nsTextEditRules.h
@@ +226,5 @@
>    /** Remove IME composition text from password buffer */
>    nsresult RemoveIMETextFromPWBuf(PRUint32 &aStart, nsAString *aIMEString);
>  
> +  nsresult CreateMozBR(nsIDOMNode* inParent, PRInt32 inOffset,
> +                       nsIDOMNode** outBRNode = NULL);

Nit: nsnull
Attachment #619394 - Flags: review?(ehsan) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/mozilla-central/rev/3859550a1cbb
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.