750112 - Flash license dialog in plugin finder service shows Firefox error page

Status: VERIFIED FIXED

(Toolkit Graveyard :: Plugin Finder Service, defect)

Description

[Alexander L. Slovesnik]

Attachment: Firefox error page in plugin finder service

STR:
1) Open page that requires Flash
2) Try to install Flash
3) In plugin finder service dialog open License agreement page

Expected result:
License is shown

Actual result:
Firefox error page is shown

Comment 1

[Matthew N. [:MattN]]

Wil, the Python port of pfs.php (pfs.py) is now being used by PFS but it doesn't return the same output for empty elements.  The python version outputs "None" instead of an empty element which causes problems like this one where Firefox tries to load http://None for the licenseURL.

Also, the data in pfs.py is older than pfs.php so it should be updated because it's causing all flash installs to fail because the hash is wrong.  We should decide which one of these scripts is going to be the canonical one and delete the other from version control (possibly with a comment pointing to the new version).

CC'ing oremj since it seems from bug 744162 comment 14 that the change to pfs.py was not well known.

Comment 2

[Wil Clouser [:clouserw]]

pfs.php is being served from https://github.com/mozilla/zamboni/blob/master/apps/amo/views.py#L172 and has newer data than the old pfs.php in SVN.

Can someone provide a URL on AMO where None is output?

Comment 3

[Matthew N. [:MattN]]

(In reply to Wil Clouser [:clouserw] from comment #2)
> Can someone provide a URL on AMO where None is output?

https://pfs.mozilla.org/plugins/PluginFinderService.php?mimetype=application/x-shockwave-flash&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2007032403&clientOS=Windowsxp&chromeLocale=en-US

Comment 4

[Wil Clouser [:clouserw]]

Thanks.  That's https://addons.mozilla.org/services/pfs.php?mimetype=application/x-shockwave-flash&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=2007032403&clientOS=Windowsxp&chromeLocale=en-US on AMO and I don't see the "None" there.  This is the same question as the other one - I don't know where pfs.m.o gets its data - apparently not AMO.  That's why I CC'd oremj

Comment 5

[Matthew N. [:MattN]]

So, is https://github.com/mozilla/zamboni/blob/master/services/pfs.py a WIP?  Is the plan to switch to it eventually?

Comment 6

[Wil Clouser [:clouserw]]

(In reply to Matthew N. [:MattN] from comment #5)
> So, is https://github.com/mozilla/zamboni/blob/master/services/pfs.py a WIP?
> Is the plan to switch to it eventually?

I think it was the first version and should be removed.

Comment 7

[Jeremy Orem [:oremj]]

We are using /data/www/addons.mozilla.org/zamboni/services/wsgi/pfs.wsgi in dev/stage/production for pfs.mozilla.org.

Comment 8

[Carsten Book [:Tomcat]]

i guess its more or less related to bug 744162

Comment 9

[Matthew N. [:MattN]]

Thanks Jeremy.  Wil says we should use pfs.py so here is my fix for the "None" showing up in the XML.

https://github.com/mnoorenberghe/zamboni/commit/7875b04aec0008ed62068ab0f5b2b68985514b45

https://github.com/mozilla/zamboni/pull/314

Maybe not the most elegant solution but it gets the job done and doesn't require Jingo/Django to render a view template.

Comment 10

[Matthew N. [:MattN]]

https://github.com/mozilla/zamboni/commit/7ac2cb7

Will take effect during the next AMO release.

Comment 11

[Matthew N. [:MattN]]

Tested on Firefox Beta on Windows XP.