750138 - Wrong response from Add-on builder helper

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Add-on Builder, defect)

Description

[Nikola Kovacs]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20100101 Firefox/12.0
Build ID: 20120420145725

Steps to reproduce:

I was developing an extension with builder.addons.mozilla.org, and had activated the test button.
I clicked on the extension in the add-ons manager, opening its details view.
I then saved a new revision


Actual results:

Installation of the new version failed. I was given a link to Bug 573778 and told to let you know of the problem, which I tried to edit, but was told I don't have permission to do so. Not very helpful. 
I tried restarting the browser, disabling and enabling the add-on helper extension, but that didn't help. I can't test my extension any more.


Expected results:

Add-on helper should not break, and it shouldn't give me a link to a bug report I can't edit.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Which addon, by the way?

Comment 2

[Nikola Kovacs]

It's a private one I'm developing.
Looks like I fixed it by uninstalling and reinstalling the helper extension again. Sorry I can't provide any useful data, I'll try to reproduce it again. But you should fix the link in the error message.

Comment 3

[Nikola Kovacs]

Ok, I managed to reproduce it:

I clicked the test button, so the addon was installed and automatically reinstalled every time I saved.
In the addon manager I clicked more to view the addon's details page.
I then opened the properties window in the builder (the rightmost gear icon), and clicked save without changing anything. The builder tried to reload the addon in my firefox, but failed. Now it's broken, and I can't load any addons for testing.
I don't know if this is relevant, but my addon has two png files in the data directory: icon.png (48x48px icon) and icon64.png (64x64px icon), and the following extra package.json properties:

{
"icon": "data/icon.png",
"icon64": "data/icon64.png"
}

The error console shows two warnings when the builder shows the error message:

Timestamp: 2012.04.30. 1:53:45
Warning: Error in parsing value for 'opacity'.  Declaration dropped.
Source File: https://builder.addons.mozilla.org/addon/1050818/latest/
Line: 0

Timestamp: 2012.04.30. 1:53:45
Warning: Expected declaration but found '['.  Skipped to next declaration.
Source File: https://builder.addons.mozilla.org/addon/1050818/latest/
Line: 0

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Alex, any thoughts on this?

Comment 5

[Alexandre Poirot [:ochameau]]

It looks like the addon icon prevents addon to be uninstalled.

InstallListener threw exception when calling onInstallEnded: 
"Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsILocalFile.remove]"
Source : resource://jid0-t3eerqgganlch9c50lpqctdunng/addons-builder-helper/lib/addon-install.js
Ligne : 38

It happens when you try to re-install/update such addon:
  https://builder.addons.mozilla.org/addon/1049610/latest/
and only when you open about:addons that most likely lock icon files!

The cool thing is that it seems to be fixed by ongoing work from bug 733582.

Comment 6

[Hallvord R. M. Steen [:hallvors]]

I'm seeing this error too, and it doesn't go away when I delete the add-on builder helper and re-install - perhaps because I have added/removed other add-ons that require a restart to complete the add/remove process, and haven't restarted yet?

Comment 7

[Wil Clouser [:clouserw]]

The builder project has been discontinued as of April 1st, 2014.

The announcement last year: https://blog.mozilla.org/addons/2013/12/18/add-on-builder/

Next steps (still being written): https://developer.mozilla.org/en-US/Add-ons/SDK/Builder