The default bug view has changed. See this FAQ.

get rid useless DEBUG_A11Y code

RESOLVED FIXED in mozilla15

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: maxli)

Tracking

(Blocks: 1 bug)

unspecified
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=eitan@monotonous.org][lang=c++])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
1) http://mxr.mozilla.org/mozilla-central/source/accessible/src/html/nsHTMLTableAccessible.cpp#1300 since the code is under SHOW_LAYOUT_HEURISTIC ifdef
2) http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsAccessNode.cpp#95 - just handing piece of code
3) http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsDocAccessible.cpp#1770 - you can do that by DOMi tool
(Reporter)

Comment 1

5 years ago
(In reply to alexander :surkov from comment #0)
> 1)
> http://mxr.mozilla.org/mozilla-central/source/accessible/src/html/
> nsHTMLTableAccessible.cpp#1300 since the code is under SHOW_LAYOUT_HEURISTIC
> ifdef

remove ifdefs

> 2)
> http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/
> nsAccessNode.cpp#95 - just handing piece of code
> 3)
> http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/
> nsDocAccessible.cpp#1770 - you can do that by DOMi tool

remove entire blocks
(Assignee)

Comment 2

5 years ago
Created attachment 619765 [details] [diff] [review]
Patch v1
Assignee: nobody → maxli
Attachment #619765 - Flags: review?(eitan)
Comment on attachment 619765 [details] [diff] [review]
Patch v1

Review of attachment 619765 [details] [diff] [review]:
-----------------------------------------------------------------

This is good. Thanks!

I am assuming that this bug is only for those 3 files and not for getting rid of DEBUG_A11Y over all. If it is, then another bug should be opened.
Attachment #619765 - Flags: review?(eitan) → review+
(Reporter)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/24f9b828d28a
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/24f9b828d28a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.