Closed
Bug 750334
Opened 9 years ago
Closed 9 years ago
rotating image appears too big during transition, then snaps to correct size
Categories
(Core :: Layout, defect)
Tracking
()
VERIFIED
FIXED
mozilla15
People
(Reporter: blassey, Assigned: mattwoodrow)
References
()
Details
(Keywords: mobile)
Attachments
(3 files)
194.93 KB,
image/png
|
Details | |
455.07 KB,
image/png
|
Details | |
1.82 KB,
patch
|
roc
:
review+
joe
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The site has a section at the top that rotates between 3 photos with a fade transition. During that transition, the images are layed out much too big. Once the transition is complete, they snap to the correct size.
Updated•9 years ago
|
blocking-fennec1.0: ? → +
So this is Fennec, not Mac desktop?
Comment 2•9 years ago
|
||
It seems so. It is some problem with how we configure image layers when we optimize thebes layers into image layers. All it takes is an image that has its opacity animated to show the problem.
Comment 3•9 years ago
|
||
Maybe related to bug 741173? Though perhaps not, going on Joe's latest comment on that bug.
Comment 5•9 years ago
|
||
(In reply to Chris Lord [:cwiiis] from comment #3) > Maybe related to bug 741173? Though perhaps not, going on Joe's latest > comment on that bug. The patch for Bug 728026 fixes Bug 741173 but doesn't fix this bug, so this seems to be a different issue.
Reporter | ||
Comment 7•9 years ago
|
||
saw this on the nytimes this morning
Updated•9 years ago
|
URL: http://rugby.mit.edu
Summary: rotating image on http://rugby.mit.edu/ appears to big during transition, then snaps to correct size → rotating image appears too big during transition, then snaps to correct size
Comment 9•9 years ago
|
||
To help debug this, I've made a minimal testcase at http://people.mozilla.org/~ajuma/opacity As noted by tn in Comment 2, all that's needed is an image that has its opacity animated.
Reporter | ||
Comment 10•9 years ago
|
||
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #1) > So this is Fennec, not Mac desktop? Yup, sorry. This is Fennec.
OS: Mac OS X → Android
Hardware: x86 → ARM
Comment 12•9 years ago
|
||
(In reply to Timothy Nikkel (:tn) from comment #2) > It is some problem with how we configure image layers when we optimize > thebes layers into image layers. Indeed; turning off the thebes layer to image layer optimization prevents the problem.
OS: Android → Mac OS X
Hardware: ARM → x86
Updated•9 years ago
|
OS: Mac OS X → Android
Hardware: x86 → ARM
Assignee | ||
Comment 13•9 years ago
|
||
I think this should fix the problem, can someone try it please :)
Attachment #623848 -
Flags: review?(roc)
Attachment #623848 -
Flags: review?(roc) → review+
Comment 14•9 years ago
|
||
Yep, that patch fixes it.
Reporter | ||
Comment 15•9 years ago
|
||
landed on inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/dd3c873674fc
Whiteboard: [inbound]
Comment 17•9 years ago
|
||
Is there a similar code path that might apply to frames of a video (bug 754434)? I can reproduce that bug even with the patch from this build.
Comment 18•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dd3c873674fc
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Comment 19•9 years ago
|
||
Issue is still reproducible on Aurora 14.0a2 2012-05-17 using http://people.mozilla.org/~ajuma/opacity. Verified fix on: Build: Nightly 15.0a1 2012-05-17 Device: HTC Desire Z OS: Android 2.3.3
Comment 20•9 years ago
|
||
Should this be uplifted?
Reporter | ||
Comment 21•9 years ago
|
||
(In reply to Kartikaya Gupta (:kats) from comment #20) > Should this be uplifted? Yes. Matt, can you please request approval?
Assignee | ||
Comment 22•9 years ago
|
||
Comment on attachment 623848 [details] [diff] [review] Always apply the scale to image layers [Approval Request Comment] Bug caused by (feature/regressing bug #): Bug 695275 User impact if declined: Misplaced images Testing completed (on m-c, etc.): Landed on m-c for almost a week, verified as fixing the issue. Risk to taking this patch (and alternatives if risky): Very low risk, just changes the scaling applied to images. String or UUID changes made by this patch: None Do we want approval for beta too?
Attachment #623848 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Attachment #623848 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•9 years ago
|
Whiteboard: [inbound]
Comment 24•9 years ago
|
||
http://hg.mozilla.org/releases/mozilla-aurora/rev/4f318c1fea77
Assignee: ajuma → matt.woodrow
Comment 26•9 years ago
|
||
Verified fixed on: Nightly 15.0a1 (2012-05-31) Aurora 14.0a2 (2012-05-30) Beta 14.0b4 Samsung Galaxy SII (2.3.4)
(In reply to Matt Woodrow (:mattwoodrow) from comment #22) > Do we want approval for beta too? Yes, we needed to get this into beta :-( to fix bug 735373.
Comment on attachment 623848 [details] [diff] [review] Always apply the scale to image layers Review of attachment 623848 [details] [diff] [review]: ----------------------------------------------------------------- Simple safe patch that fixes regression in bug 735373
Attachment #623848 -
Flags: approval-mozilla-beta?
Comment 29•9 years ago
|
||
Comment on attachment 623848 [details] [diff] [review] Always apply the scale to image layers Clearing the approval nom - this landed on aurora before migration, and should be uplifted to beta automatically
Attachment #623848 -
Flags: approval-mozilla-beta?
You need to log in
before you can comment on or make changes to this bug.
Description
•