750374 - Webapp validator not accepting some properties

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[Kev Needham [:kev]]

We've had a couple inquiries from orgs trying to submit an addon that some properties listed on MDN are being rejected by the validator with "Error: An unknown property was found in the webapp manifest". These properties are listed as "New" on the app manifest MDN page (https://developer.mozilla.org/en/Apps/Manifest), and fligtar mentioned it may be that the property whitelist isn't up to date. 

Could the whitelist be checked to ensure that all properties listed on MDN that should be accepted are in place? Specifically fullscreen, orientation, and screen_size (also, if there's a handy place to look at what's in the whitelist, could you point it out?)

Many thanks!

Comment 1

[Kev Needham [:kev]]

Is this something that can be trivially updated? We have folks trying to upload manifests and are blocking on this. Should they remove the properties to get it into the marketplace?

Comment 2

[Christopher Van Wiemeersch [:cvan]]

(In reply to Kev [:kev] Needham from comment #1)
> Is this something that can be trivially updated? We have folks trying to
> upload manifests and are blocking on this. Should they remove the properties
> to get it into the marketplace?

Web Dev is at an offsite. I'll try to get this as soon as I can - hopefully by next week's push.

Comment 3

[Kev Needham [:kev]]

Thanks, Chris. There are submissions that use a published spec that are getting rejected because of this. While I understand that people are at an offsite, this is one of those things that feels like it should be fixed as soon as possible, or we need to better coordinate publishing of manifest specs and updates of the site to ensure it doesn't happen. 

https://developer.mozilla.org/en/Apps/Manifest currently lists all of these properties without any caveats. Is there any way to push this up? I'm telling people to pull the properties that are "unknown", but it's not a great solution for the people who may be running into it and not following through.

Comment 4

[Matt Basta [:basta]]

This is my fault. I've been dealing with end-of-semester stuff. Fortunately, my last final project is due tomorrow, so I'll be free to tie up the loose ends with the validator. This should be done by the weekend.

Comment 5

[Kev Needham [:kev]]

Thanks Matt. Appreciate it!

Comment 6

[Christopher Van Wiemeersch [:cvan]]

Matt, please don't worry about this. I'm actually done with adding all the new properties. I'm just polishing up the tests and this will be done for tomorrow's (Thurs, May 3) push.

Comment 7

[Matt Basta [:basta]]

Sounds good

Comment 8

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/amo-validator/commit/fbaabdeb2c0173ad2d3fd4e1d923bc7c02cd9a07

and a few test cases:

http://apps-new.dekkostudios.com/extras/test_webapp_good.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_orientation_cannot_be_empty.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_bad_screen_size_key.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_bad_screen_size_value.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_fullscreen_bad_value.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_fullscreen_cannot_be_empty.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_fullscreen_is_string.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_fullscreen_missing.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_fullscreen_valid_value_false.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_fullscreen_valid_value_true.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_orientation_bad_value.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_orientation_empty_value.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_orientation_is_string.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_orientation_missing.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_orientation_valid_value_landscape-secondary.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_orientation_valid_value_landscape.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_orientation_valid_value_portrait-secondary.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_orientation_valid_value_portrait.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_required_features_empty.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_required_features_is_list.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_required_features_missing.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_screen_size_contains_pair.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_screen_size_is_dict.webapp
http://apps-new.dekkostudios.com/extras/test_webapp_screen_size_missing.webapp

Comment 9

[Christopher Van Wiemeersch [:cvan]]

This is live on production now:

https://marketplace.mozilla.org