750439 - SecReview: Implement DOM3 composition events

Status: RESOLVED FIXED

(mozilla.org :: Security Assurance: Review Request, task)

Description

[Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]]]

SecReview tracking bug
Actions regarding the review of the dependent bug should be tracked here.

Comment 1

[Jesse Ruderman]

If I copy the pattern in https://bug543789.bugzilla.mozilla.org/attachment.cgi?id=561673 into the DOM fuzzer, will I be testing the right thing? Or do I need to somehow test with actual IMEs, or without (content) JS on the stack?

Comment 2

[Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]]]

This bug is assigned so I am perplexed as to why it is new and not assigned?

Comment 3

[Jesse Ruderman]

Traditionally, ASSIGNED means the assignee is actively working on it.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Jesse Ruderman from comment #1)
> If I copy the pattern in
> https://bug543789.bugzilla.mozilla.org/attachment.cgi?id=561673 into the DOM
> fuzzer, will I be testing the right thing? Or do I need to somehow test with
> actual IMEs, or without (content) JS on the stack?

We can test the IME handling only for XP part by automated tests. E.g., for DOM event firing, editor behavior and so on. For testing widget part and/or combination with platform APIs or IMEs, we need the environment actually.

Comment 5

[Jesse Ruderman]

Do we have any such tests?

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

For the former, yes.

http://mxr.mozilla.org/mozilla-central/source/widget/tests/window_composition_text_querycontent.xul
http://mxr.mozilla.org/mozilla-central/source/widget/tests/window_imestate_iframes.html?force=1
http://mxr.mozilla.org/mozilla-central/source/widget/tests/test_input_events_on_deactive_window.xul
http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/text/tests/test_dom_input_event_on_texteditor.html?force=1
http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/html/tests/test_dom_input_event_on_htmleditor.html?force=1

For the latter, no. We need to test manually.

Comment 7

[Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]]]

Risk/Priority Ranking Exercise https://wiki.mozilla.org/Security/RiskRatings

Priority: N/A

Operational: 0 - N/A
User: 0 - N/A
Privacy: 0 - N/A
Engineering: 2 - Normal
Reputational: 0 - N/A

Priority Score: 0

Comment 8

[Christian Holler (:decoder)]

Jason, does Domino test these events? See e.g. comment 6. If this is covered by Domino, please just close this bug as FIXED. Thanks!

Comment 9

[Jason Kratzer [:jkratzer]]

(In reply to Christian Holler (:decoder) from comment #8)

Jason, does Domino test these events? See e.g. comment 6. If this is covered by Domino, please just close this bug as FIXED. Thanks!

Domino covers this in the context of non-privileged JS. Anything involving access to special powers (i.e. synthesizeCompositionChange) is not covered.