SecReview: Add basic support for .ico icon encoder

VERIFIED FIXED

Status

mozilla.org
Security Assurance: Review Request
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: curtisk, Assigned: posidron)

Tracking

Details

(Whiteboard: [pending secreview])

SecReview tracking bug
Actions regarding the review of the dependent bug should be tracked here.
(Assignee)

Updated

6 years ago
Assignee: dveditz → cdiehl
(Assignee)

Comment 1

6 years ago
I have tested the encoders with canvas.toDataURL() but couldn't find anything. I have used malformed PNG files as a base for encoding them to ICO, BMP and JPG.

The templates for those tests can be found inside the respective file format folder in "Peach/Resources/Templates" named "encoder.html".

However, I was able to find one crash in the Icon decoder during the tests.
(Assignee)

Updated

6 years ago
Keywords: sec-review-complete
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Keywords: sec-review-complete
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.