750443 - [in-app] Let us show user-friendly error messages

Status: RESOLVED WORKSFORME

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot

Similar to bug 746660

steps to reproduce:
1. Load http://inapp-pay-test.farmdev.com/en-US/
2. Edit the data field for price to blank
3. Click on the call mozmarket.buy()

actual behavior:
The error we show says 'RequestVerificationError' which doesn't tell the end-user a lot. Let us show something more informative and friendly instead.

Comment 1

[krupa raj[:krupa]]

One more sample:

This is on using "aud": "marketplac.mozilla.org"

Payment Error : InvalidRequest

Payment JWT aud (audience) must be set to 'marketplace.mozilla.org'; got: u'marketplac.mozilla.org' (app ID=u'ZNKFXKOFY3K9U73E5VHB')

Comment 2

[Potch [:potch]]

These are pretty now, but we still need more descriptive messages.

https://github.com/mozilla/zamboni/commit/f546974

Comment 3

[Wil Clouser [:clouserw]]

Thanks Potch.  What kind of messages did you have in mind?  Generic is probably good for the end user, with substantial logging on our end.

Comment 4

[Kumar McMillan [:kumar]]

Keep in mind that you were running in this in -dev which has debug info turned on. This exception is intended for in-app developers to understand what they did wrong. This kind of message will not be shown in production. A user would see this in production: https://bug752809.bugzilla.mozilla.org/attachment.cgi?id=621885

I'd like to keep descriptive exception messages like this in -dev to make in-app development easier. What should be changed? It currently tells you about a syntax error in the JSON and points to where to fix it.

Comment 5

[krupa raj[:krupa]]

I didn't know we had debugging enabled on -dev. Having verbose errors in -dev is definitely useful.