7505 - Search for old plug-in directory fails for Navigator 4.5

Status: VERIFIED INVALID

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Richard Cohn]

I assume this is just a temporary hack, but the code in
[modules/plugin/nglsrc/nsPluginsDirWin.cpp]nsPluginsDir::nsPluginsDir() doesn't
deal correctly with Navigator 4.5. Apparently the registry settings changed so
that you need to look for "Plugins Directory" in
HKEY_LOCAL_MACHINE\SOFTWARE\Netscape\Netscape Navigator\4.5 (en)\Main

Here's my fix:
	// RC: start add for 4.5
	result = ::RegOpenKeyEx(HKEY_LOCAL_MACHINE,
                          "Software\\Netscape\\Netscape Navigator\\4.5 (en)
\\Main",
                          0, KEY_READ, &keyloc);
	if (result == ERROR_SUCCESS)
	{
	  pathlen = sizeof(path);

	  result = ::RegQueryValueEx(keyloc, "Plugins Directory",
								 NULL, &type,
(LPBYTE)&path, &pathlen);

	  ::RegCloseKey(keyloc);
	}

	else
	{
	// RC: end add for 4.5
    result = ::RegOpenKeyEx(HKEY_CURRENT_USER,
                            "Software\\Netscape\\Netscape Navigator\\Main",
                            0, KEY_READ, &keyloc);

    if (result == ERROR_SUCCESS)
    {
      pathlen = sizeof(path);

      result = ::RegQueryValueEx(keyloc, "Install Directory",
                                 NULL, &type, (LPBYTE)&path, &pathlen);

      if (result == ERROR_SUCCESS)
      {
        PL_strcat(path, "\\Program\\Plugins");
      }

      ::RegCloseKey(keyloc);
    }

	}// RC: add brace for 4.5

Comment 1

[Alex Musil]

This works fine for me - what exact version of Com 4.5 do you have installed?

Comment 2

[Richard Cohn]

I'm running vanilla 4.5 WinNT. (Mozilla/4.5 [en] (WinNT; U))
You may not see the problem because you had a previous version of Navigator
running on the machine. Have you tried this on a machine that never had an older
version running?

Comment 3

[Alex Musil]

Reassigning Plugin bugs to Andrei

Comment 4

[av (gone)]

What you are proposing will probably not work after you install 4.51 e.g. Are
you saying that 4.5 does not write anything to
HKEY_CURRENT_USER\Software\Netscape\Netscape Navigator\Main ?

Comment 5

[Richard Cohn]

Attachment: Registry export of HKEY_CURRENT_USER\Software\Netscape

Comment 6

[Richard Cohn]

> Are you saying that 4.5 does not write anything to
> HKEY_CURRENT_USER\Software\Netscape\Netscape Navigator\Main ?
Yes. See attached registry export.

Comment 7

[av (gone)]

I just removed Navigator from my machine including folders and registry entries
and installed 4.61. Everything looks fine, i.e. it creates Main entry with
InstallDirectory specified, and 5.0 does not have any problems finding plugins.
It could be a bug in 4.5, I doubt it though...
Anyways, I do not beleive this is a 5.0 bug, and have a temptation to mark it
invalid. Beth, could you try to reproduce this with 4.5?

Comment 8

[av (gone)]

Marking invalid. If this is still an issue and a registry entry is not created
by 4.x installation, a separate bug should be filed against 4.x.

Comment 9

[Jay Patel [:jay]]

"rubber stamping" Verified Invalid...beppe, can you really verify this please?

Comment 10

[Grace Bush]

Verifying as invalid, did a clean install of 4.5 and registry entry
HKEY_CURRENT_USER\Software\Netscape\Netscape Navigator\Main shows the correct
path