750503 - [traceback] UnicodeDecodeError: 'ascii' codec can't decode byte 0xd8 in position 14413: ordinal not in range(128) | Unable to log in/login

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

When our Selenium automation runs, and tries to sign in via BrowserID on -dev (http://builder-addons-dev.allizom.org/user/browserid-login/), we're seeing the following:

Traceback (most recent call last):

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/vendor/lib/python/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/apps/person/views.py", line 201, in browserid_login
    assertion=request.POST['assertion'])

  File "/data/www/builder-addons-dev.allizom.org/flightdeck/apps/person/views.py", line 137, in browserid_authenticate
    log.error("[browserID] Error from AMO (%s): %s" % (email, str(err)))

UnicodeDecodeError: 'ascii' codec can't decode byte 0xd8 in position 14413: ordinal not in range(128)

Comment 1

[Piotr Zalewa [:zalun]]

This is fixed now although I've got no idea why - we need to check it
AMO is responding with 401 and we allow to login anyway (!)
code is not ready for production yet

Comment 2

[Piotr Zalewa [:zalun]]

I mean I know why we've not receiving the error anymore:
We no longer log the error - it's a page and raises UnicodeDecodeError when writing to the log file.
That commit fixed it
https://github.com/mozilla/FlightDeck/commit/fa55e50ef0f346fcb941ca62ef0d159eceeaca9c

We do need to investigate if user should be logged in after receiving 401 here:
https://github.com/mozilla/FlightDeck/blob/master/apps/person/views.py#L138

I do think it's sane, but it will block login on -dev

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; sorry for the late verification