Closed Bug 750555 Opened 12 years ago Closed 12 years ago

Served Linux download when accessed from Android Browser

Categories

(www.mozilla.org :: General, defect, P1)

Product:
www.mozilla.org
Component:
General
Platform:
ARM
Android
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: jfu, Assigned: sgarrity)

References

(
URL
)

Details

Attachments

(1 file)

links mis-aligned with android
13.06 KB, image/png
Details 
Expected: Served Firefox for Android download button at http://www.mozilla.org/firefox/new/ when accessed from default Android Browser 

Actual: Served Linux desktop download button 

When users search "firefox" in Google on their mobile device, the first link is http://www.mozilla.org/firefox/new/ so this site gets a lot of hits. Most users will also be converting from the default browser to Firefox. Let's try to fix this asap.
Blocks: 722846
Jlongster/Rik/Pmac: Can you three dig into this asap? This appears to be an issue with Bedrock UA detection. I am able to also replicate this problem by visiting the Bedrock back door (http://www.mozilla.org/b) and clicking the download link on the homepage that redirects me to download page and I still get the Linux download. I tested this on the old PHP site and it is working there fine and thus the issue must be with the new download buttons.
Priority: -- → P1
The redirect is handled correctly when you visit http://www.mozilla.org/firefox/ . Visiting http://www.mozilla.org/firefox/new/  directly causes this issue.
I just tested and the old button does indeed serve an Android download link.

I can work on this today. Steven also needed me to fix up the mobile download button so I can do all of this at once.
This should be fixed on dev, please test: http://www-dev.allizom.org/firefox/new/

It needs some CSS love. Steven, the android button doesn't show the locale, and the button changes width to be a lot thinner, can you fix that? I also noticed that on the main page the "English (US)" string is cut into two lines, so it would be good to fix that too. Maybe a fixed width button?
Assignee: nobody → steven
Keywords: qawanted
James, I've got the issues you raised in Comment #5 addressed in this pull request: https://github.com/mozilla/bedrock/pull/87
Assignee: steven → jlong
Steven and James , can you fix this also whiles working on this bug. Thanks

STR:
1) Visit http://www.mozilla.org/en-US/m/ on an Android mobile device
2) Click the View full site link at the bottom
3) You are redirected to http://www.mozilla.org/en-US/?mobile_no_redirect=1
4) The download button shows the link to download Firefox for Linux


Expected Result:

The download button link should be for the Firefox for Android
Thanks, Raymond!
(In reply to raymond [:retornam] from comment #8)
> 
> Expected Result:
> 
> The download button link should be for the Firefox for Android

That's exactly what this bug fixes.
I meant that my fix on dev should already fix that. Please test on dev.
Steven, I don't think your fix fixes it. Look at this page:

http://www-dev.allizom.org/en-US/firefox/new/

The (US) still wraps, and the button still collapses if it serves up the android button (because it doesn't have the locale).
(In reply to James Long (:jlongster) from comment #13)
> Steven, I don't think your fix fixes it. Look at this page:
> http://www-dev.allizom.org/en-US/firefox/new/ 
> The (US) still wraps, and the button still collapses if it serves up the
> android button (because it doesn't have the locale).

This looks correct to me - are you still seeing the problem?
(In reply to Steven Garrity from comment #15)
> (In reply to James Long (:jlongster) from comment #13)
> > Steven, I don't think your fix fixes it. Look at this page:
> > http://www-dev.allizom.org/en-US/firefox/new/ 
> > The (US) still wraps, and the button still collapses if it serves up the
> > android button (because it doesn't have the locale).
> 
> This looks correct to me - are you still seeing the problem?

Nope, looks like it was a CSS caching issue. Thanks!
Flags: in-testsuite?
(In reply to raymond [:retornam] from comment #14)
> Dev shows no button using Android on
> http://www-dev.allizom.org/en-US/?mobile_no_redirect=1
> See screenshot http://screencast.com/t/KBueGJ8cw

Works for me. Try again? Are you using a real android device or a user agent hack?

One thing I did notice is that there are 4 buttons now when the platform can't be detected, and they aren't aligned anymore. I'll attach a screenshot.
Steven, sorry to throw this your way again, but do you think you could fix the design in the above screenshot next week? We need to align the 4 buttons somehow. You can get there by settings "site.platform" to a random value in site.js.
Assignee: jlong → steven
(In reply to James Long (:jlongster) from comment #21)
> Steven, sorry to throw this your way again, but do you think you could fix
> the design in the above screenshot next week? We need to align the 4 buttons
> somehow. You can get there by settings "site.platform" to a random value in
> site.js.

Should be fixed with this: https://github.com/mozilla/bedrock/pull/96
Commits pushed to dev at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/015a51c7859160621d020af2bc250f353281afc2
Fix wrapping of fallback download buttons
(Bug 750555)

https://github.com/mozilla/bedrock/commit/86e84b21d5f1603d4df5122fa645e452c9f75934
Merge pull request #96 from sgarrity/bug-750555-android-button

Bug 750555 android button
tested using the Samsung Galaxy S default browser and was redirected to the Google Play store, but on my Samsung Galaxy Tab, I sometimes got the Linux version
It looks like caching is on -dev (X-Cache-Info):

curl -I http://www-dev.allizom.org/en-US/
HTTP/1.1 200 OK
Server: Apache
X-Backend-Server: node273.seamicro.phx1.mozilla.com
Vary: Accept-Encoding
Cache-Control: max-age=600
Content-Type: text/html; charset=utf-8
Date: Mon, 14 May 2012 20:55:48 GMT
Expires: Mon, 14 May 2012 21:06:02 GMT
Transfer-Encoding: chunked
x-frame-options: DENY
Connection: Keep-Alive
X-Cache-Info: cached

It wouldn't hurt to have IT purge Zeus cache for this URL to eliminate any additional weirdness. Also, we may just want to disable caching on -dev all together as it should not be needed.
(In reply to raymond [:retornam] from comment #24)
> tested using the Samsung Galaxy S default browser and was redirected to the
> Google Play store, but on my Samsung Galaxy Tab, I sometimes got the Linux
> version

I copied how the PHP site detects it exactly, so if it working mostly, I say let's move ahead and fix the issues with it in the future.

It may be worth turning off caching on dev, but the hard part is knowing when all the webheads have completed their update. I think even the dev server is propagated across webheads, and the update can sometimes take a little bit to happen across them.

I'm marking this fixed for now because I'd rather get this out now mostly working than let this languish since the current experience is even worse.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
(In reply to James Long (:jlongster) from comment #26)
> (In reply to raymond [:retornam] from comment #24)
> > tested using the Samsung Galaxy S default browser and was redirected to the
> > Google Play store, but on my Samsung Galaxy Tab, I sometimes got the Linux
> > version
> 
> I copied how the PHP site detects it exactly, so if it working mostly, I say
> let's move ahead and fix the issues with it in the future.
> 
> It may be worth turning off caching on dev, but the hard part is knowing
> when all the webheads have completed their update. I think even the dev
> server is propagated across webheads, and the update can sometimes take a
> little bit to happen across them.
> 
> I'm marking this fixed for now because I'd rather get this out now mostly
> working than let this languish since the current experience is even worse.

I agree
This has been pushed live.
verified fixed http://www.mozilla.org/firefox/new shows Android 12.0 download button when using an Android mobile device
Status: RESOLVED → VERIFIED
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
Flags: in-testsuite?
Flags: in-testsuite? → in-testsuite-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: