The default bug view has changed. See this FAQ.

IonMonkey: GetProp cache doesn't handle __noSuchMethod__

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sstangl, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Created attachment 619791 [details]
Patch v1.

Avoids inconsistencies in GETPROP behavior by just using GetPropOperation, as the GETELEM caches use GetElemOperation. Fixes an --ion-eager failure.

Previously we would return Undefined from the GETPROP, fail on unboxing, and then throw a TypeError at the callsite. This constructs the correct NoSuchMethod object.
Attachment #619791 - Flags: review?(dvander)
(Reporter)

Comment 1

5 years ago
Created attachment 619792 [details] [diff] [review]
Patch v1 [marked as patch]
Attachment #619791 - Attachment is obsolete: true
Attachment #619791 - Flags: review?(dvander)
Attachment #619792 - Flags: review?(dvander)
Attachment #619792 - Flags: review?(dvander) → review+
(Reporter)

Comment 2

5 years ago
https://hg.mozilla.org/projects/ionmonkey/rev/eed34f344d38
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 3

5 years ago
https://hg.mozilla.org/projects/ionmonkey/rev/321cdf2e9258
You need to log in before you can comment on or make changes to this bug.