Last Comment Bug 750573 - IonMonkey: GetProp cache doesn't handle __noSuchMethod__
: IonMonkey: GetProp cache doesn't handle __noSuchMethod__
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: general
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-30 18:02 PDT by Sean Stangl [:sstangl]
Modified: 2012-05-03 10:35 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1. (1.59 KB, text/plain)
2012-04-30 18:02 PDT, Sean Stangl [:sstangl]
no flags Details
Patch v1 [marked as patch] (1.59 KB, patch)
2012-04-30 18:03 PDT, Sean Stangl [:sstangl]
dvander: review+
Details | Diff | Splinter Review

Description Sean Stangl [:sstangl] 2012-04-30 18:02:24 PDT
Created attachment 619791 [details]
Patch v1.

Avoids inconsistencies in GETPROP behavior by just using GetPropOperation, as the GETELEM caches use GetElemOperation. Fixes an --ion-eager failure.

Previously we would return Undefined from the GETPROP, fail on unboxing, and then throw a TypeError at the callsite. This constructs the correct NoSuchMethod object.
Comment 1 Sean Stangl [:sstangl] 2012-04-30 18:03:09 PDT
Created attachment 619792 [details] [diff] [review]
Patch v1 [marked as patch]
Comment 2 Sean Stangl [:sstangl] 2012-05-01 11:42:13 PDT
https://hg.mozilla.org/projects/ionmonkey/rev/eed34f344d38
Comment 3 Sean Stangl [:sstangl] 2012-05-01 12:13:14 PDT
https://hg.mozilla.org/projects/ionmonkey/rev/321cdf2e9258

Note You need to log in before you can comment on or make changes to this bug.