Last Comment Bug 75068 - bidi diffs for gfx
: bidi diffs for gfx
Product: Core
Classification: Components
Component: XUL (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla0.9
Assigned To: Erik van der Poel
: Frank Tang
: Neil Deakin
Depends on:
  Show dependency treegraph
Reported: 2001-04-06 22:38 PDT by Erik van der Poel
Modified: 2005-03-17 13:34 PST (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

diffs for gfx (9.83 KB, patch)
2001-04-06 22:39 PDT, Erik van der Poel
no flags Details | Diff | Splinter Review

Description User image Erik van der Poel 2001-04-06 22:38:48 PDT
This bug report will be used to attach diffs from the IBM bidi project for the
gfx directory. Kevin, please review. Thanks.
Comment 1 User image Erik van der Poel 2001-04-06 22:39:43 PDT
Created attachment 30015 [details] [diff] [review]
diffs for gfx
Comment 2 User image Kevin McCluskey (gone) 2001-04-10 12:12:03 PDT
Comment 3 User image Frank Tang 2001-04-10 12:38:33 PDT
My origional concern about the GetCharacterPlacement and GetStringTypeW is gone. 
I wrote a small program which include the patch and test on Win95/Win98/WinNT/
WinME/Win2K * EN/JA/KO/TC/SC and all run fine except the GetStringTypeW may have 
issue on Arabic/Hewbrew combining mark. I think we can fix that problem later. It 
won't impact Latin and CJK text. 

erik- please check in. 
Comment 4 User image Frank Tang 2001-04-11 12:58:08 PDT
mark it as moz0.9
Comment 5 User image Erik van der Poel 2001-04-11 14:06:30 PDT
I have reviewed the patch again, and it looks good.
Comment 6 User image Erik van der Poel 2001-04-11 16:38:40 PDT
Fixes checked in.
Comment 7 User image Frank Tang 2001-04-18 11:00:38 PDT
code landing bug. change qa contact to ftang

Note You need to log in before you can comment on or make changes to this bug.