750693 - BasicListHeaderIterator.java: dep induced javac -Werror failures

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Joey Armstrong [:joey]]

/local/mozilla/bugs/748470/mobile/android/base/httpclientandroidlib/message/BasicListHeaderIterator.java:48: warning: [rawtypes] found raw type: List
    V extends Object declared in interface Map
/local/mozilla/bugs/748470/mobile/android/base/httpclientandroidlib/message/BasicListHeaderIterator.java:80: warning: [rawtypes] found raw type: List
    public HttpService(
           ^

Comment 1

[Joey Armstrong [:joey]]

Compiling w/o -Werror and -Xlint:all[,....] reported another failure point.


/local/mozilla/bugs/748470/mobile/android/base/httpclientandroidlib/message/BasicHeaderElementIterator.java:44: error: BasicHeaderElementIterator is not abstract and does not override abstract method next() in Iterator
public class BasicHeaderElementIterator implements HeaderElementIterator {
       ^
/local/mozilla/bugs/748470/mobile/android/base/httpclientandroidlib/message/BasicHeaderElementIterator.java:146: error: next() in BasicHeaderElementIterator cannot implement next() in Iterator
    public final Object next() throws NoSuchElementException {
                        ^
  return type Object is not compatible with HeaderElement
  where E is a type-variable:
    E extends Object declared in interface Iterator
/local/mozilla/bugs/748470/mobile/android/base/httpclientandroidlib/message/BasicHeaderIterator.java:40: error: BasicHeaderIterator is not abstract and does not override abstract method next() in Iterator
public class BasicHeaderIterator implements HeaderIterator {
       ^
/local/mozilla/bugs/748470/mobile/android/base/httpclientandroidlib/message/BasicHeaderIterator.java:157: error: next() in BasicHeaderIterator cannot implement next() in Iterator
    public final Object next()
                        ^
  return type Object is not compatible with Header
  where E is a type-variable:
    E extends Object declared in interface Iterator
/local/mozilla/bugs/748470/mobile/android/base/httpclientandroidlib/message/BasicListHeaderIterator.java:42: error: BasicListHeaderIterator is not abstract and does not override abstract method next() in Iterator
public class BasicListHeaderIterator implements HeaderIterator {
       ^
/local/mozilla/bugs/748470/mobile/android/base/httpclientandroidlib/message/BasicListHeaderIterator.java:171: error: next() in BasicListHeaderIterator cannot implement next() in Iterator
    public final Object next()
                        ^
  return type Object is not compatible with Header
  where E is a type-variable:
    E extends Object declared in interface Iterator
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
N

Comment 2

[Joey Armstrong [:joey]]

Attachment: fixe for javac -Werror problems

Declare types for typeless Object in BasicHeaderIterator.java and BasicListHeaderIterator.java

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.