Closed Bug 750717 Opened 8 years ago Closed 8 years ago

Output linker max virtual size using 'TinderboxPrint' so it will appear in the TBPL summary box

Categories

(Firefox Build System :: General, defect)

All
Windows Server 2003
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla15

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

Bug 710712 added the peak virtual memory usage of the linker during the final PGO link phase on Windows to each pgo log:
http://mxr.mozilla.org/mozilla-central/source/build/link.py#53

The current output is of the form:
linker max virtual size: 3021553664

It is my understanding that if we make similar to:
TinderboxPrint: linker max virtual size: 3021553664
...it will show up in the TBPL summary box, saving us from having to open each log manually. (I imagine we'll need a shorter description string)
Assignee: nobody → bmo
Severity: critical → normal
Attached patch Patch v1Splinter Review
Shortened the string a bit, hopefully that's ok compared to the others used.
Attachment #619923 - Flags: review?(ted.mielczarek)
Attachment #619923 - Flags: feedback?(philringnalda)
Status: NEW → ASSIGNED
Comment on attachment 619923 [details] [diff] [review]
Patch v1

Review of attachment 619923 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I don't care, that was a totally arbitrary string.
Attachment #619923 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 619923 [details] [diff] [review]
Patch v1

We use tiny little strings because on Tinderbox, a long string would widen the table column and thus widen the whole page and require more horizontal scrolling to see the Windows builds. But if you remember something verbose like Talos showing failure to contact the graphserver, tbpl actually has very wide columns for showing TinderboxPrint, so that should be fine (until we're sending the raw number to graphserver, at which point that should instead TinderboxPrint a couple of digits of maxvsize/1024/1024/1024 so we don't have to remember that 2962464768 is 2.75).
Attachment #619923 - Flags: feedback?(philringnalda) → feedback+
https://hg.mozilla.org/mozilla-central/rev/e1f1d4f79b2d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.