Rip out graphite from libxul

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: jfkthame)

Tracking

unspecified
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

It's that time of the year again.  We need to rip out stuff from libxul.  See bug 750661.
Created attachment 619931 [details] [diff] [review]
Disable grapohite for now
Attachment #619931 - Flags: review?(ted.mielczarek)
Attachment #619931 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 2

5 years ago
Created attachment 619945 [details] [diff] [review]
patch, restore graphite but move it to gkmedias.dll on windows

Something like this ought to work, I think - have pushed it to tryserver, and will request review if it builds ok.
(In reply to Jonathan Kew (:jfkthame) from comment #2)
> Created attachment 619945 [details] [diff] [review]
> patch, restore graphite but move it to gkmedias.dll on windows
> 
> Something like this ought to work, I think - have pushed it to tryserver,
> and will request review if it builds ok.

You may have to list exported symbols in layout/media/symbols.def.in
(Assignee)

Comment 4

5 years ago
I don't think that's needed, because of the use of GRAPHITE2_EXPORTING to get the appropriate dllexport attributes added.

Tryserver builds at https://tbpl.mozilla.org/?tree=Try&rev=24f57e880886 look happy on all desktop platforms; still waiting for android to catch up, but I believe this'll be ok.
(Assignee)

Updated

5 years ago
Attachment #619945 - Flags: review?(ted.mielczarek)
Attachment #619945 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 5

5 years ago
Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/83ff77ce8d6c
https://hg.mozilla.org/mozilla-central/rev/bfa638e5df16
https://hg.mozilla.org/mozilla-central/rev/83ff77ce8d6c
Assignee: nobody → jfkthame
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.