Rip out libpng from libxul

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

libpng needs to go outside of libxul, too!

Comment 1

5 years ago
Try run for 1ddf3f87d0bc is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=1ddf3f87d0bc
Results (out of 104 total builds):
    exception: 23
    success: 53
    warnings: 11
    failure: 17
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eakhgari@mozilla.com-1ddf3f87d0bc
Created attachment 620043 [details] [diff] [review]
Patch (v1)

This patch moves libpng into gkmedias.dll.
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #620043 - Flags: review?(ted.mielczarek)
Attachment #620043 - Flags: review?(mh+mozilla)
Comment on attachment 620043 [details] [diff] [review]
Patch (v1)

Review of attachment 620043 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/media/symbols.def.in
@@ +106,5 @@
>  ShGetInfo
>  ShConstructCompiler
>  ShGetActiveAttrib
>  ShGetActiveUniform
> +#ifndef MOZ_NATIVE_PNG

Honestly I'm really not interested in supporting native PNG on windows, but I guess it doesn't hurt to leave it here.
Attachment #620043 - Flags: review?(ted.mielczarek)
Attachment #620043 - Flags: review?(mh+mozilla)
Attachment #620043 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e58855b90cf6
Target Milestone: --- → mozilla15
This broke the build, so I backed it out for now: https://hg.mozilla.org/integration/mozilla-inbound/rev/75de3dfde0bd
Seems like that was some sort of a build system hick-up, relanded:

https://hg.mozilla.org/integration/mozilla-inbound/rev/b60dc9ae8aae
https://hg.mozilla.org/mozilla-central/rev/e58855b90cf6
https://hg.mozilla.org/mozilla-central/rev/75de3dfde0bd
https://hg.mozilla.org/mozilla-central/rev/b60dc9ae8aae
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 8

5 years ago
This one surprises me.  I thought gkmedias.dll was for things unlikely to be used during startup.
That changed in Bug 740919.
You need to log in before you can comment on or make changes to this bug.