750747 - Rip out libpng from libxul

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(no longer active)]

libpng needs to go outside of libxul, too!

Comment 1

[Mozilla RelEng Bot]

Try run for 1ddf3f87d0bc is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=1ddf3f87d0bc
Results (out of 104 total builds):
    exception: 23
    success: 53
    warnings: 11
    failure: 17
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-1ddf3f87d0bc

Comment 2

[(no longer active)]

Attachment: Patch (v1)

This patch moves libpng into gkmedias.dll.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 620043 [details] [diff] [review]
Patch (v1)

Review of attachment 620043 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/media/symbols.def.in
@@ +106,5 @@
>  ShGetInfo
>  ShConstructCompiler
>  ShGetActiveAttrib
>  ShGetActiveUniform
> +#ifndef MOZ_NATIVE_PNG

Honestly I'm really not interested in supporting native PNG on windows, but I guess it doesn't hurt to leave it here.

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e58855b90cf6

Comment 5

[(no longer active)]

This broke the build, so I backed it out for now: https://hg.mozilla.org/integration/mozilla-inbound/rev/75de3dfde0bd

Comment 6

[(no longer active)]

Seems like that was some sort of a build system hick-up, relanded:

https://hg.mozilla.org/integration/mozilla-inbound/rev/b60dc9ae8aae

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/e58855b90cf6
https://hg.mozilla.org/mozilla-central/rev/75de3dfde0bd
https://hg.mozilla.org/mozilla-central/rev/b60dc9ae8aae

Comment 8

[Jesse Ruderman]

This one surprises me.  I thought gkmedias.dll was for things unlikely to be used during startup.

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

That changed in Bug 740919.