Last Comment Bug 750747 - Rip out libpng from libxul
: Rip out libpng from libxul
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla15
Assigned To: :Ehsan Akhgari
:
: Gregory Szorc [:gps]
Mentors:
Depends on:
Blocks: 750661
  Show dependency treegraph
 
Reported: 2012-05-01 08:46 PDT by :Ehsan Akhgari
Modified: 2013-02-07 11:45 PST (History)
11 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (3.38 KB, patch)
2012-05-01 13:10 PDT, :Ehsan Akhgari
khuey: review+
Details | Diff | Splinter Review

Description :Ehsan Akhgari 2012-05-01 08:46:36 PDT
libpng needs to go outside of libxul, too!
Comment 1 Mozilla RelEng Bot 2012-05-01 12:00:24 PDT
Try run for 1ddf3f87d0bc is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=1ddf3f87d0bc
Results (out of 104 total builds):
    exception: 23
    success: 53
    warnings: 11
    failure: 17
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eakhgari@mozilla.com-1ddf3f87d0bc
Comment 2 :Ehsan Akhgari 2012-05-01 13:10:19 PDT
Created attachment 620043 [details] [diff] [review]
Patch (v1)

This patch moves libpng into gkmedias.dll.
Comment 3 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-05-01 20:01:32 PDT
Comment on attachment 620043 [details] [diff] [review]
Patch (v1)

Review of attachment 620043 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/media/symbols.def.in
@@ +106,5 @@
>  ShGetInfo
>  ShConstructCompiler
>  ShGetActiveAttrib
>  ShGetActiveUniform
> +#ifndef MOZ_NATIVE_PNG

Honestly I'm really not interested in supporting native PNG on windows, but I guess it doesn't hurt to leave it here.
Comment 5 :Ehsan Akhgari 2012-05-02 07:05:14 PDT
This broke the build, so I backed it out for now: https://hg.mozilla.org/integration/mozilla-inbound/rev/75de3dfde0bd
Comment 6 :Ehsan Akhgari 2012-05-02 08:11:25 PDT
Seems like that was some sort of a build system hick-up, relanded:

https://hg.mozilla.org/integration/mozilla-inbound/rev/b60dc9ae8aae
Comment 8 Jesse Ruderman 2012-06-02 14:34:20 PDT
This one surprises me.  I thought gkmedias.dll was for things unlikely to be used during startup.
Comment 9 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-06-02 14:42:37 PDT
That changed in Bug 740919.

Note You need to log in before you can comment on or make changes to this bug.