Closed
Bug 750760
Opened 10 years ago
Closed 10 years ago
Sites with flash ads are loading in upper left hand corner
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox14 verified, blocking-fennec1.0 +, fennec14+)
VERIFIED
FIXED
Firefox 15
People
(Reporter: tchung, Assigned: snorp)
References
()
Details
Attachments
(2 files, 1 obsolete file)
96.39 KB,
image/png
|
Details | |
3.11 KB,
patch
|
snorp
:
review+
mfinkle
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
On sites with flash ads, they are loading in the upper left hand corner of the screen. See URL for example Attaching screenshot: Repro: 1) install 5-1-2012 nightly or aurora inbound build, HTC Incredible S, Android 2.3.4 2) go to url. really any site that has flash ads (eg. www.marketwatch.com) 3) tap to play flash ads 4) Verify the flash ads will play and appear in the upper left hand corner of the screen. Expected: - Flash ads should load within its specified div Actual; - Flash ads appear in the upper left hand corner
Reporter | ||
Comment 1•10 years ago
|
||
nom'ing cause this is not an expected experience. likely regression.
blocking-fennec1.0: --- → ?
Comment 2•10 years ago
|
||
Adding test-case wanted because the bug URL has dynamic content likely to change
Keywords: testcase-wanted
Comment 3•10 years ago
|
||
Probably related to bug 749420.
Updated•10 years ago
|
tracking-fennec: --- → 15+
blocking-fennec1.0: ? → -
Reporter | ||
Comment 4•10 years ago
|
||
given this is blocking bug 727116 (marked release+), and a lot of sites using iframes will see this, i'd like to renom for fx14 triage.
tracking-fennec: 15+ → ?
blocking-fennec1.0: - → ?
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #620726 -
Flags: review?(blassey.bugs)
Updated•10 years ago
|
tracking-fennec: ? → 14+
blocking-fennec1.0: ? → +
Updated•10 years ago
|
Assignee: nobody → snorp
Comment 7•10 years ago
|
||
Comment on attachment 620726 [details] [diff] [review] Fix Android plugin positioning when iframes are used Review of attachment 620726 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/plugins/base/nsPluginInstanceOwner.cpp @@ +2868,5 @@ > > +// Modified version of nsFrame::GetOffsetToCrossDoc that stops when it > +// hits an element with a displayport (or runs out of frames) > +static nsPoint > +GetOffsetToRootIgnoreDisplayPort(nsIFrame* aFrame) GetOffsetToFrameWithDisplayPort?
Attachment #620726 -
Flags: review?(blassey.bugs) → review+
Assignee | ||
Comment 8•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #620726 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #621046 -
Flags: review+
Assignee | ||
Comment 9•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/be4204d482a2
Updated•10 years ago
|
status-firefox14:
--- → affected
Target Milestone: --- → Firefox 15
Comment 10•10 years ago
|
||
Comment on attachment 621046 [details] [diff] [review] Fix Android plugin positioning when iframes are used [Triage Comment]
Attachment #621046 -
Flags: approval-mozilla-aurora+
Reporter | ||
Comment 11•10 years ago
|
||
Reduced testcase: http://people.mozilla.org/~mwargers/tests/plugins/flash/317375_flash_wmode.swf
Keywords: testcase-wanted
Comment 12•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/be4204d482a2
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 14•10 years ago
|
||
Comment on attachment 621046 [details] [diff] [review] Fix Android plugin positioning when iframes are used Oh god this is horrible.
Comment 15•10 years ago
|
||
Comment on attachment 621046 [details] [diff] [review] Fix Android plugin positioning when iframes are used If this code stays in the tree for long I will be a very sad fellow.
Assignee | ||
Comment 16•10 years ago
|
||
(In reply to Timothy Nikkel (:tn) from comment #15) > Comment on attachment 621046 [details] [diff] [review] > Fix Android plugin positioning when iframes are used > > If this code stays in the tree for long I will be a very sad fellow. First of all, thank you for the helpful and constructive comments. Truly illuminating. Second, thanks for volunteering to fix it up. We really need someone from layout that knows this stuff better than I.
Comment 17•10 years ago
|
||
Unable to reproduce on on Nightly 15.0a1 (2012-05-20) Aurora 14.0a2 (2012-05-20) Samsung Galaxy SII (2.3.4)
Status: RESOLVED → VERIFIED
Updated•2 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•