750760 - Sites with flash ads are loading in upper left hand corner

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Tony Chung [:tchung]]

Attachment: screenshot

On sites with flash ads, they are loading in the upper left hand corner of the screen.   See URL for example

Attaching screenshot:

Repro:
1) install 5-1-2012 nightly or aurora inbound build, HTC Incredible S, Android 2.3.4
2) go to url.  really any site that has flash ads (eg. www.marketwatch.com)
3) tap to play flash ads
4) Verify the flash ads will play and appear in the upper left hand corner of the screen.

Expected:
- Flash ads should load within its specified div

Actual;
- Flash ads appear in the upper left hand corner

Comment 1

[Tony Chung [:tchung]]

nom'ing cause this is not an expected experience.   likely regression.

Comment 2

[Aaron Train [:aaronmt]]

Adding test-case wanted because the bug URL has dynamic content likely to change

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Probably related to bug 749420.

Comment 4

[Tony Chung [:tchung]]

given this is blocking bug 727116 (marked release+), and a lot of sites using iframes will see this, i'd like to renom for fx14 triage.

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Fix Android plugin positioning when iframes are used

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 620726 [details] [diff] [review]
Fix Android plugin positioning when iframes are used

Review of attachment 620726 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/base/nsPluginInstanceOwner.cpp
@@ +2868,5 @@
>  
> +// Modified version of nsFrame::GetOffsetToCrossDoc that stops when it
> +// hits an element with a displayport (or runs out of frames)
> +static nsPoint
> +GetOffsetToRootIgnoreDisplayPort(nsIFrame* aFrame)

GetOffsetToFrameWithDisplayPort?

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Fix Android plugin positioning when iframes are used

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be4204d482a2

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 621046 [details] [diff] [review]
Fix Android plugin positioning when iframes are used

[Triage Comment]

Comment 11

[Tony Chung [:tchung]]

Reduced testcase: http://people.mozilla.org/~mwargers/tests/plugins/flash/317375_flash_wmode.swf

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/be4204d482a2

Comment 13

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8c9887f3bcd9

Comment 14

[Timothy Nikkel (:tnikkel)]

Comment on attachment 621046 [details] [diff] [review]
Fix Android plugin positioning when iframes are used

Oh god this is horrible.

Comment 15

[Timothy Nikkel (:tnikkel)]

Comment on attachment 621046 [details] [diff] [review]
Fix Android plugin positioning when iframes are used

If this code stays in the tree for long I will be a very sad fellow.

Comment 16

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Timothy Nikkel (:tn) from comment #15)
> Comment on attachment 621046 [details] [diff] [review]
> Fix Android plugin positioning when iframes are used
> 
> If this code stays in the tree for long I will be a very sad fellow.

First of all, thank you for the helpful and constructive comments. Truly illuminating.

Second, thanks for volunteering to fix it up. We really need someone from layout that knows this stuff better than I.

Comment 17

[Catalin Suciu [:csuciu]]

Unable to reproduce on on Nightly 15.0a1 (2012-05-20)
                          Aurora 14.0a2 (2012-05-20)
Samsung Galaxy SII (2.3.4)