750778 - Flash plugins don't move while scrolling after switching tabs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

Tested on the Samsung Galaxy SII on the latest trunk build.

I suspect this is a regression from bug 727116, since a special Aurora build also contains the fix for that bug and also shows this bug.

Steps to reproduce:
- Go to http://people.mozilla.com/~mwargers/tests/plugins/flash/flashembed.html
- Make sure Flash plugins are running on that page and zoom in, so you can scroll on that page.
- Open a new tab and switch to that tab (or just switch directly to that tab)
- Switch back to the tab with the testcase
- Do some scrolling on that page

Expected result:
- Flash plugins scroll along with the page

Actual result:
- Flash plugins stay on a fixed position

Video here: http://www.youtube.com/watch?v=T4bS6kxajhY

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Neither snorp nor I can reproduce this. Can anyone other than Martijn see it?

Comment 2

[Tony Chung [:tchung]]

Attachment: screenshot

HTC Desire HD, 2.3.4, 5-02-nightly.

REpro:
1) Start by first using STR in bug 750760, comment 1.  Get the Flash ads into the corner of the screen like the screenshot there.  (test URL there)
2) tap awesomebar, and goto about:firefox
3) verify flash objects overlay, and you can pan up and down the about:firefox page with the flash ads locked into place.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Can you restest with an inbound build? I want to see if bug 750760 will fix this too.

Comment 4

[Tony Chung [:tchung]]

Still reproduces on 05-04 inbound.   Except this time the steps are a little different

1) load video with iframe flash, click to play
2) switch to a tab with no flash
3) switch back to first video page.   
4) pan the page, and notice flash videos dont move. 

Screencast!  http://youtu.be/PLjgldgZ2s8

Comment 5

[Tony Chung [:tchung]]

i reverted the blocking flag on accident.  can someone + again?

Comment 6

[Matt Brubeck (:mbrubeck)]

Re-set blocking-fennec1.0+

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Ensure PluginLayer is always present when plugin is visible

Comment 9

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 622060 [details] [diff] [review]
Ensure PluginLayer is always present when plugin is visible

Review of attachment 622060 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/gfx/LayerRenderer.java
@@ +275,5 @@
>          return mMaxTextureSize;
>      }
>  
>      public void addLayer(Layer layer) {
>          LayerController controller = mView.getController();

This looks to be unused

@@ +287,5 @@
>          }
>      }
>  
>      public void removeLayer(Layer layer) {
>          LayerController controller = mView.getController();

this looks to be unused

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f2444af3a1d

Comment 11

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/0f2444af3a1d

Comment 12

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 622060 [details] [diff] [review]
Ensure PluginLayer is always present when plugin is visible

[Approval Request Comment]
Trivial patch, fixes easy-to-reproduce and highly visible bug. Mobile only. Low risk.

Comment 13

[Tony Chung [:tchung]]

Verified fix on nightly, 05-14-2012.

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 622060 [details] [diff] [review]
Ensure PluginLayer is always present when plugin is visible

approving for aurora since it's verified on nightly.

Comment 15

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/319fc8878b6e

Comment 16

[Kevin Brosnan [Ex-Mozilla]]

Verified on 2012-05-17 Aurora build and 14 Beta 2.