Hide YouSendIt graph / stats if they don't finish their API in time

RESOLVED FIXED in Thunderbird 13.0

Status

Thunderbird
Preferences
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

unspecified
Thunderbird 13.0
x86
All

Thunderbird Tracking Flags

(thunderbird13+ fixed, thunderbird14- unaffected)

Details

Attachments

(5 attachments)

(Assignee)

Description

5 years ago
The YSI v2 API gives us the amount of storage space that a user has been allocated, but does not give us any information about how much storage space a user has used.

YSI is working to fix this.  In the event that they can not finish it in time, we should have a fallback for the YSI management pane.  Blake and I discussed this, and we thought that simply displaying the YSI settings link in the center of the pane would be sufficient.
(Assignee)

Updated

5 years ago
Depends on: 744010
(Assignee)

Comment 1

5 years ago
Created attachment 619964 [details] [diff] [review]
Patch v1

First go at this.
Assignee: nobody → mconley
(Assignee)

Comment 2

5 years ago
Created attachment 619965 [details]
Ubuntu
(Assignee)

Comment 3

5 years ago
Created attachment 619966 [details]
OSX
(Assignee)

Comment 4

5 years ago
Created attachment 619970 [details]
Windows 7
(Assignee)

Comment 5

5 years ago
Created attachment 619973 [details]
Windows XP
(Assignee)

Updated

5 years ago
Attachment #619964 - Flags: ui-review?(bwinton)
Attachment #619964 - Flags: review?(nisses.mail)
Comment on attachment 619964 [details] [diff] [review]
Patch v1

Looks good to me.  Thanks for the screenshots!
Attachment #619964 - Flags: ui-review?(bwinton) → ui-review+
Comment on attachment 619964 [details] [diff] [review]
Patch v1

Too bad about more px values in this code, but not much we can do about that (from poking around with DOMi for a couple of minutes) it seems.
Attachment #619964 - Flags: review?(nisses.mail) → review+
(Assignee)

Comment 8

5 years ago
Comment on attachment 619964 [details] [diff] [review]
Patch v1

David has been in communication with the YSI folks, and they don't think they can provide the values in time for TB 13, and have opted to use this placeholder instead.
Attachment #619964 - Flags: approval-comm-beta?
(Assignee)

Updated

5 years ago
tracking-thunderbird13: --- → ?
Attachment #619964 - Flags: approval-comm-beta? → approval-comm-beta+
(Assignee)

Comment 9

5 years ago
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/c1fb8dc6f817
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-thunderbird13: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
tracking-thunderbird13: ? → +
(Assignee)

Comment 10

5 years ago
David:

Do you know if YSI has finished their API for reporting storage usage stats yet?

If not, we'll need to land this on beta...

-Mike
tracking-thunderbird14: --- → ?

Comment 11

5 years ago
(In reply to Mike Conley (:mconley) from comment #10)
> David:
> 
> Do you know if YSI has finished their API for reporting storage usage stats
> yet?
I don't know. I know they've got a large patch coming to work with their v3 api, and it wouldn't surprise me if we had to use that api. I guess we've got a few weeks to decide.
tracking-thunderbird14: ? → +

Comment 12

5 years ago
the status UI does work with the v3 api patch - so the question is whether the useful parts of that can land in beta, i.e., can the patch work without string changes?
(Assignee)

Comment 13

5 years ago
Where is the v3 patch?

Comment 14

5 years ago
bug 763008

Comment 15

5 years ago
(In reply to David :Bienvenu from comment #12)
> the status UI does work with the v3 api patch - so the question is whether
> the useful parts of that can land in beta, i.e., can the patch work without
> string changes?

It looks very much like the v3 patch will land for beta.
v3 has now landed in beta for TB 14, so this is not necessary there.
status-thunderbird14: --- → unaffected
tracking-thunderbird14: + → -
You need to log in before you can comment on or make changes to this bug.