750789 - Hide YouSendIt graph / stats if they don't finish their API in time

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

The YSI v2 API gives us the amount of storage space that a user has been allocated, but does not give us any information about how much storage space a user has used.

YSI is working to fix this.  In the event that they can not finish it in time, we should have a fallback for the YSI management pane.  Blake and I discussed this, and we thought that simply displaying the YSI settings link in the center of the pane would be sufficient.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

First go at this.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Ubuntu

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: OSX

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Windows 7

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Windows XP

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 619964 [details] [diff] [review]
Patch v1

Looks good to me.  Thanks for the screenshots!

Comment 7

[Andreas Nilsson (:andreasn)]

Comment on attachment 619964 [details] [diff] [review]
Patch v1

Too bad about more px values in this code, but not much we can do about that (from poking around with DOMi for a couple of minutes) it seems.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 619964 [details] [diff] [review]
Patch v1

David has been in communication with the YSI folks, and they don't think they can provide the values in time for TB 13, and have opted to use this placeholder instead.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/c1fb8dc6f817

Comment 10

[Mike Conley (:mconley) (:⚙️)]

David:

Do you know if YSI has finished their API for reporting storage usage stats yet?

If not, we'll need to land this on beta...

-Mike

Comment 11

[David :Bienvenu]

(In reply to Mike Conley (:mconley) from comment #10)
> David:
> 
> Do you know if YSI has finished their API for reporting storage usage stats
> yet?
I don't know. I know they've got a large patch coming to work with their v3 api, and it wouldn't surprise me if we had to use that api. I guess we've got a few weeks to decide.

Comment 12

[David :Bienvenu]

the status UI does work with the v3 api patch - so the question is whether the useful parts of that can land in beta, i.e., can the patch work without string changes?

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Where is the v3 patch?

Comment 14

[David :Bienvenu]

bug 763008

Comment 15

[David :Bienvenu]

(In reply to David :Bienvenu from comment #12)
> the status UI does work with the v3 api patch - so the question is whether
> the useful parts of that can land in beta, i.e., can the patch work without
> string changes?

It looks very much like the v3 patch will land for beta.

Comment 16

[Mark Banner (:standard8)]

v3 has now landed in beta for TB 14, so this is not necessary there.