Hide YouSendIt graph / stats if they don't finish their API in time

RESOLVED FIXED in Thunderbird 13.0

Status

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

unspecified
Thunderbird 13.0
x86
All
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird13+ fixed, thunderbird14- unaffected)

Details

Attachments

(5 attachments)

The YSI v2 API gives us the amount of storage space that a user has been allocated, but does not give us any information about how much storage space a user has used.

YSI is working to fix this.  In the event that they can not finish it in time, we should have a fallback for the YSI management pane.  Blake and I discussed this, and we thought that simply displaying the YSI settings link in the center of the pane would be sufficient.
Depends on: 744010
Posted patch Patch v1Splinter Review
First go at this.
Assignee: nobody → mconley
Posted image Ubuntu
Posted image OSX
Posted image Windows 7
Posted image Windows XP
Attachment #619964 - Flags: ui-review?(bwinton)
Attachment #619964 - Flags: review?(nisses.mail)
Comment on attachment 619964 [details] [diff] [review]
Patch v1

Looks good to me.  Thanks for the screenshots!
Attachment #619964 - Flags: ui-review?(bwinton) → ui-review+
Comment on attachment 619964 [details] [diff] [review]
Patch v1

Too bad about more px values in this code, but not much we can do about that (from poking around with DOMi for a couple of minutes) it seems.
Attachment #619964 - Flags: review?(nisses.mail) → review+
Comment on attachment 619964 [details] [diff] [review]
Patch v1

David has been in communication with the YSI folks, and they don't think they can provide the values in time for TB 13, and have opted to use this placeholder instead.
Attachment #619964 - Flags: approval-comm-beta?
Attachment #619964 - Flags: approval-comm-beta? → approval-comm-beta+
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/c1fb8dc6f817
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
David:

Do you know if YSI has finished their API for reporting storage usage stats yet?

If not, we'll need to land this on beta...

-Mike
(In reply to Mike Conley (:mconley) from comment #10)
> David:
> 
> Do you know if YSI has finished their API for reporting storage usage stats
> yet?
I don't know. I know they've got a large patch coming to work with their v3 api, and it wouldn't surprise me if we had to use that api. I guess we've got a few weeks to decide.
the status UI does work with the v3 api patch - so the question is whether the useful parts of that can land in beta, i.e., can the patch work without string changes?
Where is the v3 patch?
(In reply to David :Bienvenu from comment #12)
> the status UI does work with the v3 api patch - so the question is whether
> the useful parts of that can land in beta, i.e., can the patch work without
> string changes?

It looks very much like the v3 patch will land for beta.
v3 has now landed in beta for TB 14, so this is not necessary there.
You need to log in before you can comment on or make changes to this bug.