750790 - Setting Plugins to disabled in settings shows up "Tap here to activate plugin" placeholder

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

This reminds me of bug 712975.

Steps to reproduce:
- Make sure that for Plugins you have set "Enabled" or "Tap to Play" in the Settings
- Go to http://people.mozilla.org/~mwargers/tests/plugins/flash/flashembed.html
- In the Settings, change Plugins to "Disabled".
- Reload the page

Expected result:
- "A plugin is needed to display this content" placeholders shown

Actual result:
- "Tap here to activate plugin" placeholders shown

Tested on the Samsung Galaxy Nexus.

Comment 1

[:Margaret Leibovic]

Brian, what did you do to test bug 712975? It sounds like that patch didn't actually work as expected.

I noticed that in bug 712975 comment 27 Tony verified switching between enabled/tap to play, which is unfortunate, because that already worked before that patch landed.

Comment 2

[Brian Nicholson (:bnicholson)]

This was caused by a missing chunk from a merge (https://bugzilla.mozilla.org/show_bug.cgi?id=712975#c30). This should be fixed now.