750803 - [Marketplace Reviewer Tools] Show App manifest inline on review page

Status: VERIFIED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P4)

Description

[Andrew Williamson [:eviljeff]]

A lot of the common issues with apps are due to incorrect manifests so it would be good if we could view the manifests contents on the review page.  Ajax? Either on page load or on request with a link/button

Comment 1

[Rob Hudson [:robhudson]]

This is also part of the spec...

"The manifest URL should be displayed with a link to view the manifest content without having to download and parse it."

Although I'm curious if we should display the raw text of the manifest when it was submitted? Or do an ajax request at the time the reviewer requests to see it, which may or may not match the version they are reviewing?

Comment 2

[Christopher Van Wiemeersch [:cvan]]

(In reply to Rob Hudson [:robhudson] from comment #1)
> This is also part of the spec...
> 
> "The manifest URL should be displayed with a link to view the manifest
> content without having to download and parse it."
> 
> Although I'm curious if we should display the raw text of the manifest when
> it was submitted? Or do an ajax request at the time the reviewer requests to
> see it, which may or may not match the version they are reviewing?

In my initial implementation of this I used an <iframe> but because of the Content-Type being served for the webapp Firefox would not render the contents.

It might make sense to do an AJAX request that calls a view of ours where we `urlopen` + read the manifest on the fly. Otherwise, we run into the problem of cross-domain XMLHttpRequests, which are not something we can rely on.

On a related note, we also should be dumping the contents (and not just the hash) of the manifest into the Version object.

Comment 3

[Andrew Williamson [:eviljeff]]

It should show the raw text of the manifest at the current time as that's that the user is going to get when they install the app.  The submission manifest is largely irrelevant as no-one will have installed it. (*)

Being able to see the changes in the manifest between submission, approval and at a future point will be useful for re-reviews though.

(*) I'm not sure we should handle the scenario where the manifest has changed between the cron job picking up the change (at midnight, or whatever) and now (the review time).  I've logged bug 760399 for this.

Comment 4

[Andrew Williamson [:eviljeff]]

blocks bug 766201?

Comment 5

[Christopher Van Wiemeersch [:cvan]]

Let's do an async request

    $.get('/en-US/reviewers/fetch_manifest', {'app': '<app_slug>'})

and in the view just

    return requests.get('<manifest>').content

and for good measure we might want

    requests.get('<manifest>').headers

Comment 6

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/2aec5f8

Comment 7

[krupa raj[:krupa]]

The ones I checked looked okay at https://marketplace-dev.allizom.org/en-US/reviewers/apps/review/meemoo?num=7&tab=pending

I saw one app throw a 404 but opening the manifest directly also gives an error. So, not too worried about that. See https://marketplace-dev.allizom.org/en-US/reviewers/apps/review/petoo-snowball?num=4&tab=pending

Marking this as verified. If there are issues or new features you'd like, please file a new bug.

Comment 8

[krupa raj[:krupa]]

Attachment: post-fix screenshot