formatAccessKey method of text.xml#label-control removes <children> element

RESOLVED FIXED in mozilla15

Status

()

Toolkit
XUL Widgets
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Neil Deakin, Assigned: Neil Deakin)

Tracking

unspecified
mozilla15
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

4.62 KB, patch
neil@parkwaycc.co.uk
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
Created attachment 619983 [details] [diff] [review]
patch

The line
  afterLabel.textContent = "";
causes the anonymous content including the <children> element to be removed. This causes problems with the patch in bug 653881 as this handles insertion points and default content differently.

A simple fix is to just move the <children> element outside of the <span>.
(Assignee)

Comment 1

6 years ago
Created attachment 620291 [details] [diff] [review]
updated patch with fixed test
Assignee: nobody → enndeakin
Attachment #619983 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #620291 - Flags: review?(neil)

Comment 2

6 years ago
Comment on attachment 620291 [details] [diff] [review]
updated patch with fixed test

The old binding really confuses DOM Inspector, it doesn't seem to know what's going on ;-)

>+<?xml-stylesheet href="data:text/css,k { display: inline; text-decoration: underline; }" type="text/css"?>
u would be too confusing, I suppose?

+  <label control="b5" maxwidth="50">Quite a <k>l</k>ong label. Hopefully it will wrap"</label><textbox id="b5" label="Button5" size="2"/>
Nit (×4): was the " after wrap an oversight?

>\ No newline at end of file
Nit (×2)

>-      <html:span anonid="accessKeyParens"><children/></html:span>
>+      <children/><html:span anonid="accessKeyParens"></html:span>
Remove the comment about setting .textContent too, I guess?
Attachment #620291 - Flags: review?(neil) → review+

Comment 3

6 years ago
Please can you set the milestone when landing on inbound. Thank you :-)

https://hg.mozilla.org/mozilla-central/rev/d3733e739f16
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
(Assignee)

Updated

6 years ago
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.