7509 - Embed tag doesn't recognize percentages in width & height attributes

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Richard Cohn]

If you use <embed src="..." width="100%" height="100%>, the width and height
are converted to 100 pixels. The problem is in
[layout/html/base/src/nsObjectFrame.cpp]nsPluginInstanceOwner::GetWidth which
does the following:
	*result = (PRUint32)atol(width);
So, "nnn%" gets converted to "nnn".

Comment 1

[Alex Musil]

Reassigning Plugin bugs to Andrei

Comment 2

[Eli Goldberg]

*** Bug 13929 has been marked as a duplicate of this bug. ***

Comment 3

[Eli Goldberg]

[Note to self: check OBJECT example from 13929 as part of verifying this bug.]

Comment 4

[Eli Goldberg]

Confirmed that this works properly using the embed tag on Win32 and Mac OS
(1999101208). Couldn't check Linux due to 16125.

(test case temporarily located at http://www.prometheus-music.com/meow/
plugtest.html)

Will check next on OBJECT tag.

Comment 5

[Eli Goldberg]

*** Bug 9562 has been marked as a duplicate of this bug. ***

Comment 6

[Eli Goldberg]

Attachment: Test case using OBJECT tag

Comment 7

[Eli Goldberg]

Attachment: Test case using EMBED tag

Comment 8

[Eli Goldberg]

Attachment: Flash file used by test cases

Comment 9

[Eli Goldberg]

Verifying as fixed using same builds cited in 16:08 comment. Attached the test
cases used, should anyone wish to double-check the verification.