The default bug view has changed. See this FAQ.

Remove various unused nsHTML*Element related methods

RESOLVED FIXED in mozilla15

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehren Metcalfe, Assigned: Ehren Metcalfe)

Tracking

({dev-doc-needed})

Trunk
mozilla15
dev-doc-needed
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Built on Linux without issue. None of these are scriptable.
(Assignee)

Comment 1

5 years ago
Created attachment 620189 [details] [diff] [review]
patch
Attachment #620189 - Flags: review?(jst)
Johnny, feel free to bounce the review to me if needed.
Version: unspecified → Trunk
Comment on attachment 620189 [details] [diff] [review]
patch

Nice dead code removal! The one thing that should be changed here before this lands is that we should update the IID of nsITextControlElement. Other than that this looks great! Thanks for the patch!
Attachment #620189 - Flags: review?(jst) → review+
Keywords: dev-doc-needed
(Assignee)

Comment 4

5 years ago
Created attachment 622527 [details] [diff] [review]
patch for checkin

now with updated IID for nsITextControlElement (carrying over r=jst)
Attachment #620189 - Attachment is obsolete: true
Attachment #622527 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Comment 5

5 years ago
Created attachment 622542 [details] [diff] [review]
patch for checkin

oops, last patch should have used a 2 space, not 4 space, indent for the 2nd line of the IID. Here's a fix. (carrying over r+ again)
Attachment #622527 - Attachment is obsolete: true
Attachment #622542 - Flags: review+
...I literally was updating the bug with the checkin commit when I mid-aired with you.
https://hg.mozilla.org/integration/mozilla-inbound/rev/82853146de86

Please post a follow-up patch rebased on top.
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15
Attachment #622527 - Attachment is obsolete: false
Attachment #622527 - Flags: checkin+
Attachment #622542 - Attachment is obsolete: true
Nevermind, I pushed a followup.
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2b38c2f29e7
(Assignee)

Comment 8

5 years ago
Sorry about that Ryan!
https://hg.mozilla.org/mozilla-central/rev/82853146de86
https://hg.mozilla.org/mozilla-central/rev/b2b38c2f29e7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.