Closed Bug 751052 Opened 12 years ago Closed 12 years ago

Contacts: Support SIM contacts synchronization

Categories

(Firefox OS Graveyard :: General, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gwagner, Assigned: gwagner)

References

Details

Attachments

(1 file, 2 obsolete files)

      No description provided.
Yoshi agreed to get the bits and bytes off the card (thanks yoshi!) and I will bring them into our contact format.
Depends on: 753034
Attached patch [WIP] Get FDN patch (obsolete) — Splinter Review
Hi, Gregor
  Here's the patch to get EF_FDN from simcard, try to call RIL.getFDN(). 
but currently I am not sure how to expose it to RadioInterfaceLayer. I'll check more about this.

thanks
Attached patch [WIP] Get FDN patch v2 (obsolete) — Splinter Review
add support for the UCS2 encoding in AlphaId
Attachment #622516 - Attachment is obsolete: true
Isn't FDN = fixed dialing number (http://en.wikipedia.org/wiki/Fixed_Dialing_Number)? How does this relate to the SIM phonebook? I'm probably missing something... :)
(In reply to Philipp von Weitershausen [:philikon] from comment #4)
> Isn't FDN = fixed dialing number
Yes, after discussing on Monday we start with FDN, which is simpler.
Now I am working on ADN part, which if on a USIM it means EF_PBR, which is the SIM phonebook you mention.
Ok. I suggest filing separate RIL bugs for these things and keeping this bug about the Contacts DB integration.
Depends on: 754018
No longer depends on: 753034
(In reply to Philipp von Weitershausen [:philikon] from comment #6)
> Ok. I suggest filing separate RIL bugs for these things and keeping this bug
> about the Contacts DB integration.

Hi philikon, 
I file Bug 754018 for RIL.

thanks
Priority: -- → P2
Attached patch patchSplinter Review
Assignee: nobody → anygregor
Depends on: 754018
Attachment #626221 - Flags: review?(jonas)
Comment on attachment 626221 [details] [diff] [review]
patch

Review of attachment 626221 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that fixed.

Though, do we usually leave debug statements like these in?

::: dom/contacts/ContactManager.js
@@ +390,5 @@
> +        debug("got SIM contacts: " + aType + " " + JSON.stringify(aContacts));
> +        let result = new Array();
> +        for (let contact in aContacts) {
> +          let c = {name: [aContacts[contact].alphaId], tel: [{number: aContacts[contact].number}]};
> +          result.push(c);

I think this might be somewhat cleaner done using Array.map. Something like:

result = aContacts.map(function(c) { return { name: [c.alphaId], tel: [c.number] } });
Attachment #626221 - Flags: review?(jonas) → review+
https://hg.mozilla.org/mozilla-central/rev/e9fdaa6a3655
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: