751149 - "test-traceback.testFromExceptionWithError" fails with "throwErro != throwError"

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Alexandre Poirot [:ochameau]]

Stack exposed by exception object has recently changed:

  var Cu = Components.utils;
  function foo(a, b) {
    return new Error().stack;
  }
  Cu.reportError(foo("a", "b"));

In FF12 we have the following string:
  foo("a","b")@Scratchpad:12
  @Scratchpad:14

Whereas we get this in Nightly:
  foo@Scratchpad:12
  @Scratchpad:14

So function arguments are no more displayed on stack trace.
It ends up breaking our string parser in traceback.js

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 422

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/95bb7e77e256c6ddd57b2c4eb3b1a6d5f921b4a9
Bug 751149: Support new exception stack format.

https://github.com/mozilla/addon-sdk/commit/f061390491466c014a75c7666cf138017180b933
Merge pull request #422 from ochameau/bug/751149-fix-traceback

Bug 751149: Support new exception stack format. r=@mossop

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

So this is the only thing still failing on Aurora after bug 751077 landed there tonight.
I think we just need to land a change to jetpack-location.txt to get Aurora testing our latest SDK code that includes this fix.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

And Aurora is magically green again on the lastest push to the SDK... 
https://tbpl.mozilla.org/?noignore=1&tree=Jetpack&rev=97b724debc39

Huh.