"test-traceback.testFromExceptionWithError" fails with "throwErro != throwError"

RESOLVED FIXED

Status

Add-on SDK
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ochameau, Assigned: ochameau)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Stack exposed by exception object has recently changed:

  var Cu = Components.utils;
  function foo(a, b) {
    return new Error().stack;
  }
  Cu.reportError(foo("a", "b"));

In FF12 we have the following string:
  foo("a","b")@Scratchpad:12
  @Scratchpad:14

Whereas we get this in Nightly:
  foo@Scratchpad:12
  @Scratchpad:14

So function arguments are no more displayed on stack trace.
It ends up breaking our string parser in traceback.js
(Assignee)

Comment 1

6 years ago
Created attachment 620303 [details]
Pull request 422
Assignee: nobody → poirot.alex
Attachment #620303 - Flags: review?(rFobic)
Attachment #620303 - Flags: review?(rFobic) → review+

Comment 2

6 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/95bb7e77e256c6ddd57b2c4eb3b1a6d5f921b4a9
Bug 751149: Support new exception stack format.

https://github.com/mozilla/addon-sdk/commit/f061390491466c014a75c7666cf138017180b933
Merge pull request #422 from ochameau/bug/751149-fix-traceback

Bug 751149: Support new exception stack format. r=@mossop
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
So this is the only thing still failing on Aurora after bug 751077 landed there tonight.
I think we just need to land a change to jetpack-location.txt to get Aurora testing our latest SDK code that includes this fix.

Updated

6 years ago
Depends on: 753628
And Aurora is magically green again on the lastest push to the SDK... 
https://tbpl.mozilla.org/?noignore=1&tree=Jetpack&rev=97b724debc39

Huh.
You need to log in before you can comment on or make changes to this bug.