751225 - [d2c] Firefox version mentioned in the incompatibility info message is incorrect

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

Firefox 4.0.1

steps to reproduce:
1. Load https://addons-dev.allizom.org/en-US/firefox/addon/gmail-notifier/?src=search in Firefox 4.0.1
2. Click on the install button
3. Notice that the incompatibility warning says that the user should be on Firefox 10 or higher.
4. Check the Firefox version range supported by the add-on.

observed behavior:
the add-on only supports firefox versions Firefox 3.0 - 3.7a1pre. We hsouldn't be telling the user that the add-on can be used on Firefox 10.

Comment 1

[Rob Hudson [:robhudson]]

The intention here is to explain that compatible by default can only work on Firefox 10 or higher.  From the bug I'm not sure what the correct behavior should be.  Should we simply update the wording? Something else?

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Because this add-on's compatibility range is 3.0-3.7a1pre and D2C works for only 4.0+, we're incorrectly telling the user that if he/she upgrades to Firefox 10+ this add-on will be compatible. But that's false.

Comment 3

[krupa raj[:krupa]]

We should word it better. Most people will assume that we are saying that the add-on will work if they have Firefox 10 or higher which isn't the case.

Greg, thoughts?

Comment 4

[Rob Hudson [:robhudson]]

Perhaps we simply not display this reason if the add-on minVersion isn't 4+ to avoid the confusion.

Comment 5

[Gregory Koberger (:gkoberger)]

Users should never hear anything about d2c. It's confusing and nobody cares. 

I think that for any of the tooltips, we should only tell them why it doesn't qualify if there's a way for them to fix it (upgrade their browser, turn off strictCompatibility, etc).

So, in this case, the reason is: "This add-on hasn't been updated to work with your version of Firefox."

I'm not sure what to do about things like binary components. Sure, the reason you can't use it is because the add-on has binary components. But why bother telling the user? There's nothing they can do about it. I think the proper error message for that would be "This add-on hasn't been updated to work with your version of Firefox."

Comment 6

[Gregory Koberger (:gkoberger)]

Also, Rob, I realize my last comment kinda goes against what we've talked about before. Sorry about that! I've been thinking about it a lot and it doesn't make sense to me to show errors to the user that they can't fix.

That being said, I'm going to file a bug today to surface these errors to developers when they upload a new version.

Comment 8

[Wil Clouser [:clouserw]]

Davor or Allen: Can either of you sync up with Rob to give him a hand with this?  He can explain where he's at.

Comment 9

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/c6698b0

For add-ons that aren't updated for d2c (e.g. those with Fx maxVersion < 4.0), don't bother showing the d2c reasons.

Comment 10

[Rob Hudson [:robhudson]]

Attachment: Install button screenshot