751348 - Profile reset throws an error

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[David Burns :automatedtester]

>>> profile.reset()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "mozprofile/profile.py", line 94, in reset
    addons=self.addon_manager.addons,
AttributeError: 'AddonManager' object has no attribute 'addons'

Comment 1

[David Burns :automatedtester]

Attachment: Pointer to Github pull request: https://github.com/mozilla/mozbase/pull/11

Pointer to Github pull-request

Comment 2

[Jeff Hammel]

Comment on attachment 620514 [details]
Pointer to Github pull request: https://github.com/mozilla/mozbase/pull/11

This works for me.  I'm not a huge fan of the property declarations, but they're probably fine here.  Also, +1 for tests! \o/

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Once fixed can we please make sure to also get a version bump and push it to pypi? thanks.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

When will this code land?

Comment 5

[cmtalbert]

(In reply to Henrik Skupin (:whimboo) from comment #4)
> When will this code land?

It's been fixed for three days: https://github.com/mozilla/mozbase/commit/872902a82ee8597c04b471fa6166f06e869372f0

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We should take care of open bugs in this case. Also no new version of the package has been uploaded yet to PyPI. So no other application can benefit from this change. David, would be nice if you could cover open requests on a bug you own in the future.

I will re-use this bug for the version bump and upload to PyPI tasks. Given that I'm not able to push a new release to PyPI I need someone else to do so once the patch has been merged.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

So the version for mozprofile has been bumped from 0.2 to 0.3:
https://github.com/mozilla/mozbase/commit/40d1878e29cae857a09665dcb4e339ef907f992c

Also the mozprofile-0.3 tag has been created:
https://github.com/mozilla/mozbase/commits/mozprofile-0.3

Can someone please push mozprofile 0.3 to PyPI? Thanks.

Comment 8

[David Burns :automatedtester]

(In reply to Henrik Skupin (:whimboo) from comment #6)
> David, would be nice if you could cover open requests on a
> bug you own in the future.
> 

Seeing as this was done just before I finished for a long weekend I think getting it done today was reasonable. 

Henrik, it would be nice if you asked someone else that might be able to help when I am on holiday rather than suggesting that the bug was not followed through. 

> Can someone please push mozprofile 0.3 to PyPI? Thanks.

I will coordinate with jhammel, or jhammel if you read this before I do then awesome, thanks!

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to David Burns :automatedtester from comment #8)
> Seeing as this was done just before I finished for a long weekend I think
> getting it done today was reasonable. 
> 
> Henrik, it would be nice if you asked someone else that might be able to
> help when I am on holiday rather than suggesting that the bug was not
> followed through. 

There was no mentioning for a long weekend on our list or anywhere else. So other people may not be aware of it. Also I strongly believe that merging a pull right before end of the day should also give enough time to give at least a comment on the bug. Especially if it's a blocking issue for a couple of different projects. People depend on this fix, so we could have already fixed it yesterday. So please help us in the future with follow-up tasks you plan or ask if someone else can cover it. Thanks.

> > Can someone please push mozprofile 0.3 to PyPI? Thanks.
> 
> I will coordinate with jhammel, or jhammel if you read this before I do then
> awesome, thanks!

Thanks.

Comment 10

[Jeff Hammel]

You should now both have pypi access to mozprofile.

Comment 11

[David Burns :automatedtester]

MozProfile 0.3 has been released.

Comment 12

[Dave Hunt [:davehunt] [he/him] ⌚BST]

It looks like this was changed after the initial review to add an 's' to a variable [1] name, which caused another failure. 

AttributeError: 'AddonManager' object has no attribute 'installed_manifest'

[1] https://github.com/AutomatedTester/mozbase/commit/83a9e3425d044e9dcaf8864492a54844d2847022

Comment 13

[David Burns :automatedtester]

unfortunately when I ran my tests again it didnt pick it up and I forgot to look at the CI 

Fixed in 
https://github.com/mozilla/mozbase/commit/4e0cdb3c19a5da1455290e1010b8da15118400ad

and MozProfile 0.3.1 released to pypi.