Last Comment Bug 751356 - Pres shell arena allocation methods should be inlined and non-virtual
: Pres shell arena allocation methods should be inlined and non-virtual
Status: RESOLVED FIXED
: perf
Product: Core
Classification: Components
Component: Layout (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla15
Assigned To: Mats Palmgren (:mats)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-02 14:07 PDT by Mats Palmgren (:mats)
Modified: 2012-05-10 07:41 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (13.34 KB, patch)
2012-05-02 14:15 PDT, Mats Palmgren (:mats)
no flags Details | Diff | Splinter Review
fix, v2 (10.73 KB, patch)
2012-05-02 16:47 PDT, Mats Palmgren (:mats)
bzbarsky: review+
Details | Diff | Splinter Review

Description Mats Palmgren (:mats) 2012-05-02 14:07:49 PDT
We should inline AllocateFrame etc, at least under _IMPL_NS_LAYOUT 
http://mxr.mozilla.org/mozilla-central/source/layout/base/nsIPresShell.h#226
Comment 1 Mats Palmgren (:mats) 2012-05-02 14:15:16 PDT
Created attachment 620465 [details] [diff] [review]
fix

Do we need to expose non-_IMPL_NS_LAYOUT versions at all?

https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=67684568dbcf
Comment 2 Boris Zbarsky [:bz] (still a bit busy) 2012-05-02 14:21:38 PDT
I don't think we do.
Comment 3 Mats Palmgren (:mats) 2012-05-02 16:47:57 PDT
Created attachment 620524 [details] [diff] [review]
fix, v2

OK, great.  So, I tried to wrap these in #ifdef _IMPL_NS_LAYOUT but it
didn't work out... I had to wrap nsPresContext::AllocateFromShell too
and that led to compile errors because they are used in inline methods
in nsStyleStruct.h, which gets pulled in from parser/html and layout/ipc
etc (through nsIFrame.h, nsDisplayList.h), so I don't really see a good
solution to solve these dependencies... the cost seems to outweigh the
benefit of the #ifdef

https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=4512f68bc191
Comment 4 Mats Palmgren (:mats) 2012-05-09 08:54:04 PDT
bz, review ping?
Comment 5 Boris Zbarsky [:bz] (still a bit busy) 2012-05-09 09:11:05 PDT
Comment on attachment 620524 [details] [diff] [review]
fix, v2

Hmm.  The review request mail went AWOL...

r=me
Comment 7 Ed Morley [:emorley] 2012-05-10 07:41:24 PDT
https://hg.mozilla.org/mozilla-central/rev/d682dd9d93ea

Note You need to log in before you can comment on or make changes to this bug.