We should inline AllocateFrame etc, at least under _IMPL_NS_LAYOUT http://mxr.mozilla.org/mozilla-central/source/layout/base/nsIPresShell.h#226
Created attachment 620465 [details] [diff] [review] fix Do we need to expose non-_IMPL_NS_LAYOUT versions at all? https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=67684568dbcf
I don't think we do.
Created attachment 620524 [details] [diff] [review] fix, v2 OK, great. So, I tried to wrap these in #ifdef _IMPL_NS_LAYOUT but it didn't work out... I had to wrap nsPresContext::AllocateFromShell too and that led to compile errors because they are used in inline methods in nsStyleStruct.h, which gets pulled in from parser/html and layout/ipc etc (through nsIFrame.h, nsDisplayList.h), so I don't really see a good solution to solve these dependencies... the cost seems to outweigh the benefit of the #ifdef https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=4512f68bc191
bz, review ping?
Comment on attachment 620524 [details] [diff] [review] fix, v2 Hmm. The review request mail went AWOL... r=me