Look into removing CAPS strings from stringbundle

RESOLVED FIXED in mozilla22

Status

()

Core
Security: CAPS
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Bobby Holley (On Leave Until June 11th), Assigned: Cykesiopka)

Tracking

unspecified
mozilla22
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=bholley])

Attachments

(1 attachment)

Component: Canvas: 2D → Security: CAPS
QA Contact: canvas.2d → caps
Whiteboard: [mentor=bholley]
(Assignee)

Comment 1

5 years ago
Created attachment 722600 [details] [diff] [review]
Proposed Patch

From what I can tell, "Yes" and "ExtensionCapability" are only used in test-app-strings.js.

I didn't think it would be necessary to keep the two strings around just for one test, so I chose what I thought would be suitable replacements...
Attachment #722600 - Flags: review?(bzbarsky)
Comment on attachment 722600 [details] [diff] [review]
Proposed Patch

Why do we need to keep around CheckMessage?

r=me modulo that.
Attachment #722600 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

5 years ago
(In reply to Boris Zbarsky (:bz) from comment #2)
> Comment on attachment 722600 [details] [diff] [review]
> Proposed Patch
> 
> Why do we need to keep around CheckMessage?
> 
> r=me modulo that.

It's used here:
https://mxr.mozilla.org/mozilla-central/source/security/manager/pki/resources/content/clientauthask.js#27
Ah, thank you.
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea9b4ef5df58
Assignee: nobody → cykesiopka
Keywords: checkin-needed

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/ea9b4ef5df58
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22

Updated

5 years ago
Blocks: 851007

Comment 8

5 years ago
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/78a193e577555d2915206a235dbd6c6f65ed2782
Bug 751378 - Remove unused CAPS strings from stringbundle to fix bug 851007. r=bz
(cherry picked from commit e58b0d16fb226db9513814c5d288c313ad72f76f)

Comment 9

5 years ago
Commit pushed to integration at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/e58b0d16fb226db9513814c5d288c313ad72f76f
Bug 751378 - Remove unused CAPS strings from stringbundle. r=bz
You need to log in before you can comment on or make changes to this bug.