The default bug view has changed. See this FAQ.

Telephony tests: JavascriptException: TypeError: navigator is undefined

RESOLVED FIXED in mozilla15

Status

Testing
Marionette
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jgriffin, Assigned: jgriffin)

Tracking

unspecified
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I got the webapi tests running again, see http://brasstacks.mozilla.com/autolog/?tree=b2g&source=autolog.  Unfortunately, something broke the telephony tests between now and the last time they ran, 24 days ago.
(Assignee)

Comment 1

5 years ago
Created attachment 620508 [details] [diff] [review]
telephony tests patch

The fix to all these tests is to replace navigator with window.navigator.  I don't know why this necessary now...I tried looking through commits but I couldn't identify any obvious candidates that would have caused this.

We could add the navigator property directly to the sandbox instead; I don't really have an opinion on which is better, do you?
Attachment #620508 - Flags: review?(mdas)
Comment on attachment 620508 [details] [diff] [review]
telephony tests patch

Review of attachment 620508 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

I would prefer not to include navigator in the sandbox if we don't have to. It makes the test unclear, and it makes the Marionette server responsible for things it shouldn't care about.
Attachment #620508 - Flags: review?(mdas) → review+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/mozilla-central/rev/a0356446a56a
Assignee: nobody → jgriffin
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
(In reply to Jonathan Griffin (:jgriffin) from comment #1)
> The fix to all these tests is to replace navigator with window.navigator.  I
> don't know why this necessary now...I tried looking through commits but I
> couldn't identify any obvious candidates that would have caused this.

This seems like something worth investigating, lest it end up being caused by a more serious bug that causes more problems later. It shouldn't be necessary to prefix navigator with "window.".
(Assignee)

Comment 5

5 years ago
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #4)
> 
> This seems like something worth investigating, lest it end up being caused
> by a more serious bug that causes more problems later. It shouldn't be
> necessary to prefix navigator with "window.".

Gavin's right; this is a regression in gecko and not something to do with Marionette.  I'll file a separate bug.
(Assignee)

Comment 6

5 years ago
Filed as bug 751699
You need to log in before you can comment on or make changes to this bug.