Closed Bug 751479 Opened 12 years ago Closed 12 years ago

java.lang.NullPointerException: at org.mozilla.gecko.ui.PanZoomController.onScale(PanZoomController.java)

Categories

(Firefox for Android Graveyard :: General, defect)

15 Branch
ARM
Android
defect
Not set
critical

Tracking

(firefox14 verified, firefox15 verified)

VERIFIED FIXED
Firefox 15
Tracking Status
firefox14 --- verified
firefox15 --- verified

People

(Reporter: scoobidiver, Assigned: kats)

Details

(Keywords: crash, Whiteboard: [native-crash])

Crash Data

Attachments

(1 file)

There's one crash in 15.0a1/20120205: bp-3c849db6-2142-402d-9cb6-2e1842120502.

java.lang.NullPointerException
	at org.mozilla.gecko.ui.PanZoomController.onScale(PanZoomController.java:887)
	at org.mozilla.gecko.ui.SimpleScaleGestureDetector.sendScaleGesture(SimpleScaleGestureDetector.java:230)
	at org.mozilla.gecko.ui.SimpleScaleGestureDetector.onTouchMove(SimpleScaleGestureDetector.java:127)
	at org.mozilla.gecko.ui.SimpleScaleGestureDetector.onTouchEvent(SimpleScaleGestureDetector.java:90)
	at org.mozilla.gecko.gfx.TouchEventHandler.dispatchEvent(TouchEventHandler.java:225)
	at org.mozilla.gecko.gfx.TouchEventHandler.handleEvent(TouchEventHandler.java:174)
	at org.mozilla.gecko.gfx.LayerView.onTouchEvent(LayerView.java:118)
	at android.view.View.dispatchTouchEvent(View.java:4621)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1560)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1333)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1560)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1333)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1560)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1333)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1560)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1333)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:1560)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1333)
	at com.android.internal.policy.impl.PhoneWindow$DecorView.superDispatchTouchEvent(PhoneWindow.java:1863)
	at com.android.internal.policy.impl.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1287)
	at android.app.Activity.dispatchTouchEvent(Activity.java:2309)
	at com.android.internal.policy.impl.PhoneWindow$DecorView.dispatchTouchEvent(PhoneWindow.java:1836)
	at android.view.View.dispatchPointerEvent(View.java:4689)
	at android.view.ViewRoot.deliverPointerEvent(ViewRoot.java:2365)
	at android.view.ViewRoot.handleMessage(ViewRoot.java:2034)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:132)
	at android.app.ActivityThread.main(ActivityThread.java:4028)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:491)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:844)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:602)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.ui.PanZoomController.onScale%28PanZoomController.java%29
Attached patch PatchSplinter Review
mLastZoomFocus is null in a call to onScale. I suppose this might happen if we get a move event with two touch points without first getting a touchstart with two points on the very first scale action. I couldn't repro this myself but it might be that on some devices or in some conditions the touchstart gets delivered to a different view/activity. This patch guards the general case of having onScale called without onScaleBegin called first.
Assignee: nobody → bugmail.mozilla
Attachment #620812 - Flags: review?(chrislord.net)
Comment on attachment 620812 [details] [diff] [review]
Patch

Review of attachment 620812 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #620812 - Flags: review?(chrislord.net) → review+
https://hg.mozilla.org/mozilla-central/rev/ba3af080c9c1
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 620812 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: rare chance of crash when pinch zooming for the first time; exact steps to repro unknown
Testing completed (on m-c, etc.): baked on m-c
Risk to taking this patch (and alternatives if risky): fairly low risk, mobile-only
String changes made by this patch: none
Attachment #620812 - Flags: approval-mozilla-aurora?
We are leaving all non-beta+ bugs nominated for Aurora approval in the queue until FN14 Beta 1 is signed off on by QA.
Comment on attachment 620812 [details] [diff] [review]
Patch

have gotten sign off on FN 14 beta 1, so all clear to land now.
Attachment #620812 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified by crash stats inspection.
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: