Note: There are a few cases of duplicates in user autocompletion which are being worked on.

fix and reenable toolkit/components/ctypes/tests/unit/test_finalizer_shouldaccept.js

RESOLVED FIXED in mozilla15

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: luke, Assigned: Yoric)

Tracking

unspecified
mozilla15
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

5 years ago
A new xpcshell test started failing with cpg (bug 650353).  Given that it is only failing on one platform (OSX 10.5 opt) and in finalization, we are suspicious of the test having some timing or order dependency.  Given that this is a new feature, it seems ok to temporarily disable the test (rather than backing out cpg and a bunch of related patches) and investigate pronto.
I will look at it.
Assignee: general → dteller

Updated

5 years ago
Blocks: 720771
Created attachment 620669 [details] [diff] [review]
Better memory cleanup during the test.

Propagating the cleanup introduced for bug 745233.
Attachment #620669 - Flags: review?(jorendorff)
Created attachment 620676 [details] [diff] [review]
Better memory cleanup during the test.

Sorry for the confusion, this patch should apply cleanly.
Attachment #620669 - Attachment is obsolete: true
Attachment #620669 - Flags: review?(jorendorff)
Attachment #620676 - Flags: review?(jorendorff)

Comment 4

5 years ago
Disabled test on inbound to green the tree up for now:
https://hg.mozilla.org/integration/mozilla-inbound/rev/94913b445e72
Whiteboard: [leave open]
Comment on attachment 620676 [details] [diff] [review]
Better memory cleanup during the test.

Yup. It looks like test_to_int should be fixed up too.
Attachment #620676 - Flags: review?(jorendorff) → review+
Created attachment 620705 [details] [diff] [review]
Better memory cleanup during the test.

Added a second clean-up, just in case.
Attachment #620676 - Attachment is obsolete: true
Attachment #620705 - Flags: review?(jorendorff)
Attachment #620705 - Flags: review?(jorendorff) → review+
Keywords: checkin-needed
Created attachment 620707 [details] [diff] [review]
Better memory cleanup during the test.

Same patch, but with a newline.
Attachment #620705 - Attachment is obsolete: true
Attachment #620707 - Flags: review+
Blocks: 745184
https://hg.mozilla.org/integration/mozilla-inbound/rev/720b32b1ef1e
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [leave open]
Target Milestone: --- → mozilla15

Comment 9

5 years ago
(In reply to Ed Morley [:edmorley] from comment #4)
> Disabled test on inbound to green the tree up for now:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/94913b445e72

https://hg.mozilla.org/mozilla-central/rev/94913b445e72
> Created attachment 620707 [details] [diff] [review]
> Better memory cleanup during the test.

https://hg.mozilla.org/mozilla-central/rev/720b32b1ef1e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.