Closed Bug 751505 Opened 11 years ago Closed 11 years ago

fix and reenable toolkit/components/ctypes/tests/unit/test_finalizer_shouldaccept.js

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla15

People

(Reporter: luke, Assigned: Yoric)

References

Details

Attachments

(1 file, 3 obsolete files)

Better memory cleanup during the test.
2.01 KB, patch
Yoric
: review+
Details | Diff | Splinter Review 
A new xpcshell test started failing with cpg (bug 650353).  Given that it is only failing on one platform (OSX 10.5 opt) and in finalization, we are suspicious of the test having some timing or order dependency.  Given that this is a new feature, it seems ok to temporarily disable the test (rather than backing out cpg and a bunch of related patches) and investigate pronto.
I will look at it.
Assignee: general → dteller
Propagating the cleanup introduced for bug 745233.
Attachment #620669 - Flags: review?(jorendorff)
Sorry for the confusion, this patch should apply cleanly.
Attachment #620669 - Attachment is obsolete: true
Attachment #620669 - Flags: review?(jorendorff)
Attachment #620676 - Flags: review?(jorendorff)
Disabled test on inbound to green the tree up for now:
https://hg.mozilla.org/integration/mozilla-inbound/rev/94913b445e72
Whiteboard: [leave open]
Comment on attachment 620676 [details] [diff] [review]
Better memory cleanup during the test.

Yup. It looks like test_to_int should be fixed up too.
Attachment #620676 - Flags: review?(jorendorff) → review+
Added a second clean-up, just in case.
Attachment #620676 - Attachment is obsolete: true
Attachment #620705 - Flags: review?(jorendorff)
Attachment #620705 - Flags: review?(jorendorff) → review+
Same patch, but with a newline.
Attachment #620705 - Attachment is obsolete: true
Attachment #620707 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/720b32b1ef1e
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [leave open]
Target Milestone: --- → mozilla15
(In reply to Ed Morley [:edmorley] from comment #4)
> Disabled test on inbound to green the tree up for now:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/94913b445e72

https://hg.mozilla.org/mozilla-central/rev/94913b445e72
> Created attachment 620707 [details] [diff] [review]
> Better memory cleanup during the test.

https://hg.mozilla.org/mozilla-central/rev/720b32b1ef1e
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.