751608 - Remove the never implemented hidePage method

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

hidePage has never been implemented, we should just remove it from nsIBrowserHistory and remove its non-implementation

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 620778 [details] [diff] [review]
Patch

Review of attachment 620778 [details] [diff] [review]:
-----------------------------------------------------------------

looks like you forgot the non-implementation: http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/nsNavHistory.cpp#3223

Comment 3

[Marco Castelluccio [:marco]]

Attachment: Patch v2

Oops, looks like I searched "hidePage" through mxr with the case sensitive option :)

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 621035 [details] [diff] [review]
Patch v2

Review of attachment 621035 [details] [diff] [review]:
-----------------------------------------------------------------

Needs SR and...

::: toolkit/components/places/nsIBrowserHistory.idl
@@ -158,5 @@
> -     *
> -     * @note If the page hasn't been visited yet, then it will be added
> -     *       as if it was visited, and then marked as hidden
> -     */
> -    void hidePage(in nsIURI aURI);

Need to rev the uuid, unless you land this in the same push with bug 739221, that is already doing that.

Comment 5

[Marco Castelluccio [:marco]]

> Need to rev the uuid, unless you land this in the same push with bug 739221,
> that is already doing that.

This was the plan :)

Comment 6

[Marco Castelluccio [:marco]]

We should land this along with bug 739221.

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/45bfaaa0da83

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/45bfaaa0da83

Comment 9

[Eric Shepherd [:sheppy]]

Removed from documentation:

https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsIBrowserHistory

This is mentioned on Firefox 15 for developers as well.