751609 - Playing Flash video yields black screen -- Surface::lock failed, already locked messages

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Aurora/Nightly (05/03) - Raw log

After a half dozen attempts to trigger the play button after activating plugins on Android.com, the entire viewport turns black and my log is continuously flooded with

E/Surface ( 9926): Surface::lock failed, already locked


--
Nightly (05/03), Aurora (05/03)
Samsung Galaxy Note (Android 2.3)

Comment 1

[Aaron Train [:aaronmt]]

This leaves Fennec completely non-functional; new load attempts at new sites leave the throbber spinning and nothing happening, looping:

E/Surface ( 9926): Surface::lock failed, already locked

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

I suspect this is a regression from bug 727116, can QA please confirm that?

Comment 3

[Aaron Train [:aaronmt]]

Confirmed.

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b5c0d6abf69b&tochange=cfaf90b22fc3

Comment 4

[Tony Chung [:tchung]]

not sure yet if its a dupe of bug 750963

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Give up on locking a Surface after 10 failures

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

With the above patch, we block for a maximum of ~5ms and give up after that. The result is that you won't see the placeholder which looks nice during pan/zoom and instead the plugin SurfaceView will kind of lag behind. Sucks, but apparently there is something going on with the Note that causes a problem here.

Comment 7

[Aaron Train [:aaronmt]]

Can reproduce on an inbound from this afternoon so 'the looper patch' didn't fix this.

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/90e8e70edff1

Comment 9

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/mozilla-central/rev/90e8e70edff1

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 621137 [details] [diff] [review]
Give up on locking a Surface after 10 failures

[Triage Comment]

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4306b3474838

Comment 12

[Cristian Nicolae (:xti)]

This issue is not reproducible anymore on the latest Nightly and Aurora builds. Closing bug as verified fixed on:

Firefox 15.0a1 (2012-05-30)
Firefox 14.0a2 (2012-05-30)

Device: Galaxy Nexus
OS: Android 4.0.2