Closed Bug 751674 Opened 14 years ago Closed 12 years ago

automationutils.checkForCrashes needs to gracefully handle symbolsPath == None

Categories

(Testing :: General, defect)

Product:
Testing
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 738029

People

(Reporter: catlee, Unassigned)

Details

My build is crashing somewhere doing its PGO run, and generating this python exception: MOZ_PGO_INSTRUMENTED=1 OBJDIR=obj-firefox JARLOG_DIR=obj-firefox/jarlog/en-US python obj-firefox/_profile/pgo/profileserver.py 10 args: ['/builds/slave/m-in-lnx-pgo/build/obj-firefox/dist/firefox/firefox-bin', '-no-remote', '-profile', '/builds/slave/m-in-lnx-pgo/build/obj-firefox/_profile/pgo/pgoprofile/', 'http://localhost:8888/index.html'] INFO | automation.py | Application pid: 23348 Xlib: extension "RANDR" missing on display ":2.0". (firefox-bin:23348): Pango-WARNING **: failed to choose a font, expect ugly output. engine-type='PangoRenderFc', script='common' Traceback (most recent call last): File "obj-firefox/_profile/pgo/profileserver.py", line 92, in <module> timeout = None) File "/builds/slave/m-in-lnx-pgo/build/obj-firefox/_profile/pgo/automation.py", line 905, in runApp self.checkForCrashes(profileDir, symbolsPath) File "/builds/slave/m-in-lnx-pgo/build/obj-firefox/_profile/pgo/automation.py", line 837, in checkForCrashes automationutils.checkForCrashes(os.path.join(profileDir, "minidumps"), symbolsPath, self.lastTestSeen) File "/builds/slave/m-in-lnx-pgo/build/obj-firefox/_profile/pgo/automationutils.py", line 188, in checkForCrashes if isURL(symbolsPath): File "/builds/slave/m-in-lnx-pgo/build/obj-firefox/_profile/pgo/automationutils.py", line 144, in isURL return len(urlparse(thing).scheme) >= 2 File "/usr/lib/python2.6/urlparse.py", line 129, in urlparse tuple = urlsplit(url, scheme, allow_fragments) File "/usr/lib/python2.6/urlparse.py", line 168, in urlsplit i = url.find(':') AttributeError: 'NoneType' object has no attribute 'find' TEST-UNEXPECTED-FAIL | automation.py | Exited with code 1 during test run INFO | automation.py | Application ran for: 0:00:02.055763 INFO | automation.py | Reading PID log: /tmp/tmpm728zPpidlog Looks like crashreporter is running as well, which is probably bad.
The crux of this is that checkForCrashes needs to gracefully handle symbolsPath being None.
Component: Build Config → General
Product: Firefox → Testing
QA Contact: build.config → general
Summary: profileserver.py should handle crashes better → automationutils.checkForCrashes needs to gracefully handle symbolsPath == None
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.